From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688DFC43461 for ; Thu, 17 Sep 2020 09:37:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 013152076D for ; Thu, 17 Sep 2020 09:37:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 013152076D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8FD836B0062; Thu, 17 Sep 2020 05:37:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 886B46B0068; Thu, 17 Sep 2020 05:37:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 775E36B006C; Thu, 17 Sep 2020 05:37:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0103.hostedemail.com [216.40.44.103]) by kanga.kvack.org (Postfix) with ESMTP id 5C2F16B0062 for ; Thu, 17 Sep 2020 05:37:12 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 2129DB9F9 for ; Thu, 17 Sep 2020 09:37:12 +0000 (UTC) X-FDA: 77272049904.02.tramp59_5503f2627121 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id EDDA0100D3F84 for ; Thu, 17 Sep 2020 09:37:11 +0000 (UTC) X-HE-Tag: tramp59_5503f2627121 X-Filterd-Recvd-Size: 2353 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 17 Sep 2020 09:37:11 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id DED1F3F0AC; Thu, 17 Sep 2020 09:37:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id DBB563F0AB; Thu, 17 Sep 2020 09:37:10 +0000 (UTC) Date: Thu, 17 Sep 2020 09:37:10 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Marco Elver cc: akpm@linux-foundation.org, glider@google.com, hpa@zytor.com, paulmck@kernel.org, andreyknvl@google.com, aryabinin@virtuozzo.com, luto@kernel.org, bp@alien8.de, catalin.marinas@arm.com, dave.hansen@linux.intel.com, rientjes@google.com, dvyukov@google.com, edumazet@google.com, gregkh@linuxfoundation.org, mingo@redhat.com, jannh@google.com, Jonathan.Cameron@huawei.com, corbet@lwn.net, iamjoonsoo.kim@lge.com, keescook@chromium.org, mark.rutland@arm.com, penberg@kernel.org, peterz@infradead.org, cai@lca.pw, tglx@linutronix.de, vbabka@suse.cz, will@kernel.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v2 04/10] mm, kfence: insert KFENCE hooks for SLAB In-Reply-To: <20200915132046.3332537-5-elver@google.com> Message-ID: References: <20200915132046.3332537-1-elver@google.com> <20200915132046.3332537-5-elver@google.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: EDDA0100D3F84 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 15 Sep 2020, Marco Elver wrote: > @@ -3206,7 +3207,7 @@ static void *____cache_alloc_node(struct kmem_cache *cachep, gfp_t flags, > } > > static __always_inline void * > -slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, > +slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_size, > unsigned long caller) > { The size of the object is available via a field in kmem_cache. And a pointer to the current kmem_cache is already passed to the function. Why is there a need to add an additional parameter?