From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F38C433DF for ; Tue, 30 Jun 2020 02:07:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB3332068F for ; Tue, 30 Jun 2020 02:06:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="If10uPjK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB3332068F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 770398D0025; Mon, 29 Jun 2020 22:06:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 721758D001D; Mon, 29 Jun 2020 22:06:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 60FFA8D0025; Mon, 29 Jun 2020 22:06:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0028.hostedemail.com [216.40.44.28]) by kanga.kvack.org (Postfix) with ESMTP id 4883E8D001D for ; Mon, 29 Jun 2020 22:06:59 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BFC1C1EE6 for ; Tue, 30 Jun 2020 02:06:58 +0000 (UTC) X-FDA: 76984240116.13.skin97_0e0cf5b26e74 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 92BEB18140B70 for ; Tue, 30 Jun 2020 02:06:58 +0000 (UTC) X-HE-Tag: skin97_0e0cf5b26e74 X-Filterd-Recvd-Size: 3935 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 30 Jun 2020 02:06:58 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id j12so8704450pfn.10 for ; Mon, 29 Jun 2020 19:06:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=tKQUz3ss+SkTXPIo7jFWCtq27AsIgeg6pLQv0LW7H5k=; b=If10uPjK3MMTzI9xXwJGQ1cOGcfuYSR1WRyeBbR/PUH6HL167ChvfNuykRXPnAT0cq KZecDQ1zb2SO+BQwnIZgpK+3kmSVcMkSmTOaZgG0YVSu79JyyH9jSv+r5sG00UsqQhsA fSQY7wQNnXymqWXBV+/3TMQ/L/NpZDENPkhBKjsbPvd/3SvfjQA/6y/yf5Wi/uZZWnYR mctfTPL0BIozB/gQkBh3pjpFkrHO/lwm4+OdzAKBlnhHurdAMnk0gBPbClEp3ijxw8kM FFQMusVF1UPrVKLkzodKeSE7dYo8v/ZnmiB1XQryYgNgD5CeSwikDDfnJ2ju495mKxzw COxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=tKQUz3ss+SkTXPIo7jFWCtq27AsIgeg6pLQv0LW7H5k=; b=LwmLRfKu5vE1zw4+U/JUtjrRREBJ/UGOrCvUZj6QhhLbLUvDkskRyZ09iudlBGnQPV qyU83P4dTUHkTm/CYZ6TyWHXhX+SDKZo65KIAkqlWqp579srt686qy0hcPOek9Pl1Zue YUjLG+z0t9oYMj5v0ffyYS5hdumK3GUUo8kyuOmG4M1Tu65+cTwmVrLmGIeM/C3ZxocX 95M6A/AP1vicxh1B+YgwUMaNOFSzc8+e8pJJl3GfR2OoODa9qI4SDsdvxgEzLJIJxluV OOvtld4bdXrx5ChDUOtzXN/oUt3v+gQNM452lDtqTeGXdAF0E70nNhBFi9po+Hz4i/XM VlMA== X-Gm-Message-State: AOAM531kEv2Yv40XXuHJPxLCzrUJU15h05voXcCX/88kOB13HBJqfnMU wtBtvRIMwket0X5GCIdd4czDnQ== X-Google-Smtp-Source: ABdhPJxMPe/26T/Qx87OxAuBF9dw0hq9HKbcu78S+099W6oaXpno8coYO1yGzLPj8dY4SSuKUW7iUw== X-Received: by 2002:a65:5a4d:: with SMTP id z13mr10194621pgs.336.1593482816918; Mon, 29 Jun 2020 19:06:56 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id a8sm818795pfi.29.2020.06.29.19.06.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 19:06:56 -0700 (PDT) Date: Mon, 29 Jun 2020 19:06:55 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: =?UTF-8?B?6IuP6L6J?= cc: Mike Rapoport , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re:Re: [PATCH] mm: remove the redundancy code In-Reply-To: <3f4b9136.1440.17302f60674.Coremail.sh_def@163.com> Message-ID: References: <20200629173047.GA38128@ubuntu> <20200629202429.GG1492837@kernel.org> <3f4b9136.1440.17302f60674.Coremail.sh_def@163.com> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="1482994552-1160537174-1593482816=:1118534" X-Rspamd-Queue-Id: 92BEB18140B70 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002186, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --1482994552-1160537174-1593482816=:1118534 Content-Type: text/plain; charset=GBK Content-Transfer-Encoding: quoted-printable On Tue, 30 Jun 2020, =CB=D5=BB=D4 wrote: > I am sorry that i did not consider the memory hotplug case, > and i think we should add a new param to distinguish two different case= s. >=20 No need, we can simply continue setting zone->zone_start_pfn unless there= =20 is a bug to be fixed (and, if so, please send a bug report). Removing it= =20 would not improve anything and would only increase risk. --1482994552-1160537174-1593482816=:1118534--