From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDC85C433E1 for ; Mon, 29 Jun 2020 18:50:19 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A4E57206A1 for ; Mon, 29 Jun 2020 18:50:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="H/jEqMD1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4E57206A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1FBC26B0078; Mon, 29 Jun 2020 14:50:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AC6A6B007D; Mon, 29 Jun 2020 14:50:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09C6E6B0080; Mon, 29 Jun 2020 14:50:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0217.hostedemail.com [216.40.44.217]) by kanga.kvack.org (Postfix) with ESMTP id E5BA86B0078 for ; Mon, 29 Jun 2020 14:50:18 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 817392DFC for ; Mon, 29 Jun 2020 18:50:18 +0000 (UTC) X-FDA: 76983139716.12.grain66_4f0481826e71 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 352D01800FB60 for ; Mon, 29 Jun 2020 18:50:18 +0000 (UTC) X-HE-Tag: grain66_4f0481826e71 X-Filterd-Recvd-Size: 3777 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 29 Jun 2020 18:50:17 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id b184so1867496pfa.6 for ; Mon, 29 Jun 2020 11:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=IvtcfFZZb6MrwnG6pfelExB/xyAxufFTua0HopUMxCU=; b=H/jEqMD1SdPz6aA0pAK8ExCaF3JVkU35Md8uqDiJLGEEGf7E5Leit4kCJJ1irK9uIb Tzx6RKVhPjKznVV634fxBlhD9fMVYiRVb/MmZRnN9Qq5ikDNYxyzq0YNseNiceylR7tL KYLHl0LE6ur7y11jNaH7Ugj8sFCWRn9rw3XDdJkWG8mJcxCo5sWLxNL+NBMxJqEqaUwi X+X/M1/BWx0+c504Rm7O3KDFBHmrznaS9OK5h5UYz0C3uA0aJwmrlVLO7AODVCASBl3i QN6Raks5jplfCGtxAE++JPFO42hrsDclow1zfk89aWp55h09EMI+Qx8SZzMJ+w39iIkn Splg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=IvtcfFZZb6MrwnG6pfelExB/xyAxufFTua0HopUMxCU=; b=SD5U5UCrJNqfrpGljUJGs8TjZwbPTKugbBB3zRuH1ZcLqonUrG97cdrsgGJ2QwYhrJ +mLCWWe1b4eyzipS7UtVfBEISO4/31MFgunlgZQLWJan4AlDktzje4Y9QFzvtCmZ8Ou7 /Pl7ghrdZJ1JMB5nPaNdJciIjGeQNH8IWryuV6A46ZOJDNLJV5UkwIqRvQRXokh6q9QU fw+JU45qcveEEC1nER+eR//5dJn5CENfHw/XNdz8UWpmt+qGeQ5BB0Sa56vwqn4Y1Mip 7Phknq3Xgw5SLG72E9pV8lLzoxYIoW3pMRWJGqDZMiCUr/5Igndb83wCA+TrI3zkds8S D/QA== X-Gm-Message-State: AOAM53349zfhuoiJCoeXceyCtYJG4+RCdNYpPK7vhMDrT8D6/XnyrgDg bVWBlGhlOTiJODBUtHR5B0lOFw== X-Google-Smtp-Source: ABdhPJxL3kQ0LFQSbczS6Y5Fq3oezIBxASxtVF6xl94kQKNiE4hpG9cpR01wPsXtOn/372mJgk3tKA== X-Received: by 2002:a63:525a:: with SMTP id s26mr11270037pgl.155.1593456616190; Mon, 29 Jun 2020 11:50:16 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id x22sm406823pfr.11.2020.06.29.11.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jun 2020 11:50:15 -0700 (PDT) Date: Mon, 29 Jun 2020 11:50:15 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Su Hui cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: remove the redundancy code In-Reply-To: <20200629173047.GA38128@ubuntu> Message-ID: References: <20200629173047.GA38128@ubuntu> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 352D01800FB60 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 30 Jun 2020, Su Hui wrote: > remove the redundancy code, the zone_start_pfn > is assigned from zone->zone_start_pfn > Signed-off-by: Su Hui I don't think this is redundant, it's used by memory hotplug when onlining new memory. > --- > mm/page_alloc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 3c4eb750a199..3372a8c9fbc4 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6215,8 +6215,6 @@ void __meminit init_currently_empty_zone(struct zone *zone, > if (zone_idx > pgdat->nr_zones) > pgdat->nr_zones = zone_idx; > > - zone->zone_start_pfn = zone_start_pfn; > - > mminit_dprintk(MMINIT_TRACE, "memmap_init", > "Initialising map node %d zone %lu pfns %lu -> %lu\n", > pgdat->node_id,