From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9887DC47257 for ; Fri, 8 May 2020 18:31:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 616E52192A for ; Fri, 8 May 2020 18:31:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PkJiY+3y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 616E52192A Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E2C0D8E0005; Fri, 8 May 2020 14:31:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DDA498E0003; Fri, 8 May 2020 14:31:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF0638E0005; Fri, 8 May 2020 14:31:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0003.hostedemail.com [216.40.44.3]) by kanga.kvack.org (Postfix) with ESMTP id B745E8E0003 for ; Fri, 8 May 2020 14:31:15 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 82154181AEF07 for ; Fri, 8 May 2020 18:31:15 +0000 (UTC) X-FDA: 76794394110.14.frame73_623f40d86ae0c X-HE-Tag: frame73_623f40d86ae0c X-Filterd-Recvd-Size: 4347 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Fri, 8 May 2020 18:31:15 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id q124so1226500pgq.13 for ; Fri, 08 May 2020 11:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=pY+mOo2Ik3rWYLJPySMCfrE7K/NG/f57s6xPPFkwDCg=; b=PkJiY+3yDvfK1RMaphrVSJxAZpHPlVI96LEh2eF2DJK/y+VeUnFxraKDe7pkx2MuAA +cUITO2x/tJ7OBopd14bySnct6EKLJ3S0kFLbGGBTTtIos4FeYvFuzsNhG6LywDUEijZ MHedNbeyfE6eQ7j566t3oabeyBFhxHBGzyVUHnpMPdWonR03zIenUbDZj6QKdyKKMRDl xMIgEN1Cgv0PeI1K3qh50jsX5jkm5nkvUY9tRFUhN4UCCwxYLlDPhZ22/7pJRqk2K7cT c2CmPEWmMskfAjI6jWPYfQyl6ATM3UYK3zt28fKbe9omD0Su07J+GsklQlpC52qEvxjK xxfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=pY+mOo2Ik3rWYLJPySMCfrE7K/NG/f57s6xPPFkwDCg=; b=IBaijKILtqJF23AYB1IWh2ezeSD7Hm9Kz+beS3RzZzSkfvZBWF+u4xth25ZqKAXpfr zcw0MhmFZuJVOke+7Qj+5uvNlpMGhRnexKjtpP6AxsBo6xqCfYG90XYgTOVeDzmy23fQ NsP8au7MaXYKkrNYaMQkkh/Ip+gatw963nOaSwR93iuEY+NsXJ5JebSBCM7P69umPFwY GoMJxem2/A1lsuridYjza1Cvyw7o1OaSHgQ5X07jHfgl+hQbX8pGpY1yTAHhvNb20TYc an1FuXDi9xE9+i8SWZYwt97Qa5pN29px7SI2tjEsJOfqoDN4qDSNmr2WEoG/yIpHzvFH sUyw== X-Gm-Message-State: AGi0PubSUNVbOMxhe6xZCt59k2+FHY1hZYrpaLrkYpjTj6/nwAetLFd6 XotJGCYseiqZSAZkavafQTbCDQ== X-Google-Smtp-Source: APiQypJ1g8NDV78SKY142EWfkEa8+kvMzzernl5mLgqHih9spEDfMFhunr2OUyji/1PmP4qP5WrvNw== X-Received: by 2002:a62:7656:: with SMTP id r83mr4109824pfc.71.1588962673869; Fri, 08 May 2020 11:31:13 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id j7sm2407521pfi.160.2020.05.08.11.31.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2020 11:31:13 -0700 (PDT) Date: Fri, 8 May 2020 11:31:12 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Guilherme G. Piccoli" cc: Andrew Morton , "Guilherme G. Piccoli" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gavin Guo , Mel Gorman Subject: Re: [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl In-Reply-To: Message-ID: References: <20200507215946.22589-1-gpiccoli@canonical.com> <20200507160438.ed336a1e00c23c6863d75ae5@linux-foundation.org> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 7 May 2020, Guilherme G. Piccoli wrote: > Well...you can think that the problem we are trying to solve was more > like...admin forgot if they triggered or not the compaction hehe > So, counting on the user to keep track of it is what I'd like to > avoid. And thinking about drop_caches (that have an indication when > triggered) makes me think this indeed does make sense for compaction > too. > Cheers, > It doesn't make sense because it's only being done here for the entire system, there are also per-node sysfs triggers so you could do something like iterate over the nodemask of all nodes with memory and trigger compaction manually and then nothing is emitted to the kernel log. There is new statsfs support that Red Hat is proposing that can be used for things like this. It currently only supports KVM statistics but adding MM statistics is something that would be a natural extension and avoids polluting both the kernel log and /proc/vmstat.