From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED93C432C0 for ; Sun, 17 Nov 2019 04:58:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8515D20874 for ; Sun, 17 Nov 2019 04:58:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="a/3JWGzt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8515D20874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D3A406B0003; Sat, 16 Nov 2019 23:58:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE9376B0006; Sat, 16 Nov 2019 23:58:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C00166B0007; Sat, 16 Nov 2019 23:58:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id A873D6B0003 for ; Sat, 16 Nov 2019 23:58:02 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 5A0AF5856 for ; Sun, 17 Nov 2019 04:58:02 +0000 (UTC) X-FDA: 76164562404.09.sense14_6336e0c7dc83c X-HE-Tag: sense14_6336e0c7dc83c X-Filterd-Recvd-Size: 4810 Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Sun, 17 Nov 2019 04:58:01 +0000 (UTC) Received: by mail-pg1-f196.google.com with SMTP id h27so7936016pgn.0 for ; Sat, 16 Nov 2019 20:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=jEgcbLffHvInuudf1yxHrJupAep1eByuwcjffM5aOvc=; b=a/3JWGztuOAbEsz9msqcvd9nTRMEET4rlDcOuI2gbNGMsUc12lezwTIotPcZPOfSto WDi5TpG/Dhh3/PhkjsSe8K0caDhzTdWV9Ir3B2mTcbDgcN1gP5L8a2a/PS28n1mLqGIb E9XApBJBUbMjJDcX/eMUarB1Kq+0ywGsq056YIUuRivb8eah0lfGIw/Tv5L8De3BPQq/ Sq3E34e12B05O3owK+5JN4t70jRFeU7aphHF66OaAXuF/z6vKcEyq4xax3RxrLBllcLa r32x8vNm73s5/CYifOwU370+nfyeFLqm6o67TT9FvgcfAJELoLuIZXY2W2eo5sVVAjrD vjEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=jEgcbLffHvInuudf1yxHrJupAep1eByuwcjffM5aOvc=; b=tuEaGgq/96sdQZ6Zs3yJx7j9Xfx6/vy6zXNYPtUZiyhlhsf5eER+fd6JoHT93WQ+jo tbl85D+03vpI+dJfOwqSCVPvczpPoHoAoRCLCg0g5jhwmWPtWJIR1PqbtxHZa4CODi3J p58wVSU3LAaFJmk+GXDaUlNWXeV02mgGS8goiAYUP8BVOMxNcf1OaQtY0AQyaJmLRlDm QNsaTV1QcqXFNcutJFrymtLg+W6uiURyjNpvSNhrAW1hvZYpfnFUgdhn0YZDeNjZ8AwZ VN+zfW6pVg3sahx3VViYhDI3u9OxCx3Mx1GiIoqlXLk0DAWX/3w90csFMNTnNMN31bPm kyQw== X-Gm-Message-State: APjAAAWzQ+1gKMwD/caZNK1/K1f9acple2ZET81GVOwQgDapzDH4B04t arpzPcnJn5C4oPesdhToToEjTw== X-Google-Smtp-Source: APXvYqw/trc/1O1AypH6tmLPpsAPixu8z/SqLT0y6hDUX8FDf31UAw3DYcCxUKNNRS/lE8JtSappkQ== X-Received: by 2002:a63:1f08:: with SMTP id f8mr8309321pgf.145.1573966680566; Sat, 16 Nov 2019 20:58:00 -0800 (PST) Received: from localhost ([2600:1011:b043:4c6e:3bc6:3ed3:dc27:5ef3]) by smtp.gmail.com with ESMTPSA id j20sm15436653pff.182.2019.11.16.20.57.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Nov 2019 20:58:00 -0800 (PST) Date: Sat, 16 Nov 2019 20:57:55 -0800 (PST) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: dvyukov@google.com, glider@google.com, aryabinin@virtuozzo.com cc: Nick Hu , corbet@lwn.net, palmer@sifive.com, aou@eecs.berkeley.edu, tglx@linutronix.de, gregkh@linuxfoundation.org, alankao@andestech.com, Anup.Patel@wdc.com, atish.patra@wdc.com, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org, green.hu@gmail.com Subject: Re: [PATCH v4 1/3] kasan: No KASAN's memmove check if archs don't have it. In-Reply-To: <20191028024101.26655-2-nickhu@andestech.com> Message-ID: References: <20191028024101.26655-1-nickhu@andestech.com> <20191028024101.26655-2-nickhu@andestech.com> User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello Andrey, Alexander, Dmitry, On Mon, 28 Oct 2019, Nick Hu wrote: > If archs don't have memmove then the C implementation from lib/string.c is used, > and then it's instrumented by compiler. So there is no need to add KASAN's > memmove to manual checks. > > Signed-off-by: Nick Hu If you're happy with this revision of this patch, could you please ack it so we can merge it as part of the RISC-V KASAN patch set? Or if you'd prefer to take this patch yourself, please let me know. - Paul > --- > mm/kasan/common.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index 6814d6d6a023..897f9520bab3 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -107,6 +107,7 @@ void *memset(void *addr, int c, size_t len) > return __memset(addr, c, len); > } > > +#ifdef __HAVE_ARCH_MEMMOVE > #undef memmove > void *memmove(void *dest, const void *src, size_t len) > { > @@ -115,6 +116,7 @@ void *memmove(void *dest, const void *src, size_t len) > > return __memmove(dest, src, len); > } > +#endif > > #undef memcpy > void *memcpy(void *dest, const void *src, size_t len) > -- > 2.17.0 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv > - Paul