From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82E71CA9EB3 for ; Fri, 18 Oct 2019 02:58:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3FD6F21897 for ; Fri, 18 Oct 2019 02:58:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sifive.com header.i=@sifive.com header.b="dU09HL7Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FD6F21897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C6E138E0005; Thu, 17 Oct 2019 22:58:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C1D4D8E0003; Thu, 17 Oct 2019 22:58:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0B1A8E0005; Thu, 17 Oct 2019 22:58:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0018.hostedemail.com [216.40.44.18]) by kanga.kvack.org (Postfix) with ESMTP id 876E58E0003 for ; Thu, 17 Oct 2019 22:58:09 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 00EB8802BC27 for ; Fri, 18 Oct 2019 02:58:09 +0000 (UTC) X-FDA: 76055396256.23.coal17_4713087508a03 X-HE-Tag: coal17_4713087508a03 X-Filterd-Recvd-Size: 4048 Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Oct 2019 02:58:08 +0000 (UTC) Received: by mail-io1-f66.google.com with SMTP id z19so5717168ior.0 for ; Thu, 17 Oct 2019 19:58:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=6vl776tt39Djj97+yEKzgcDA8S7SdrfVeVZOrfDrtPA=; b=dU09HL7YiUwk/maqwxoin70k8Ds5wcr8FCr03pp80PJHAKOp3OReif4boc/KD+b2DM J85QCudqpCs1TCoMc9wVPTRMRU0STpgD/1QlgpUBNod7Cl0dHQT0+cS+GqwwKn1pTQoh qDbr/RW6USHBn1Lwi3PUSRcsIdwJasq0mwWOSN/6upWfMh7UN21nQLP+JZJjujE1EJbf sUB+YacJewIY1v4hglgcqfHidAp7zxIlzY5AWW/L7aOkuYBKghGCKY1Qjy7HoZc4IpvO ig+ikN0mJIZGCo3VIdRDOweYsfcUzSaai36eoZbFKR8i5RlAmAWDLaVCq5E1yt0FO8qa Fflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=6vl776tt39Djj97+yEKzgcDA8S7SdrfVeVZOrfDrtPA=; b=cdL+1rsnLIgC5EnuELIQa7jV6wogEPaU4h6xOydVBEhG2KEvrQDT4+nyavSsohU+5+ hR/eP8TS0vozNC49Uxs4Q26eKM+6OA/PFy3VYCKK18fyOLtFof5QTafd/y5y7q3TfZQH FT9rR1w4vniZtz+reIxyj4ZRSLNd/B0WIr8fd/Kqnd6iHtpbY4unQINUZNCqEYYEEG+U FE2JNUnJEtwVmjUqB59m7GDg3N+E/COxiUr4bld8Ayq9q9y1Fk9NNYOrHAWN6ITLhR/i KNSPH2GOkxyB+z/RD4MSvZVrG/q9wJUs3XLejfAO37dnPAgXnvLpWIKhznCB2bIqMNXW TMbw== X-Gm-Message-State: APjAAAUf3olmGQSovWkxrQMW4nJFz6mOZasNCb2J6WhNcANU71+gI8ZG CiKkaxJwyAO8a0LZZMcIzlHqsA== X-Google-Smtp-Source: APXvYqzmzVECICRUhTk0jHEyAsknDFm8SCMbAaOwaHumsoit6u726yoCOL3R0yOSUQ676wBRE6GLoQ== X-Received: by 2002:a05:6602:1c4:: with SMTP id w4mr6000255iot.153.1571367487601; Thu, 17 Oct 2019 19:58:07 -0700 (PDT) Received: from localhost ([64.62.168.194]) by smtp.gmail.com with ESMTPSA id o66sm2100434ili.45.2019.10.17.19.58.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Oct 2019 19:58:06 -0700 (PDT) Date: Thu, 17 Oct 2019 19:58:04 -0700 (PDT) From: Paul Walmsley X-X-Sender: paulw@viisi.sifive.com To: Nick Hu , Andrey Ryabinin cc: alankao@andestech.com, palmer@sifive.com, aou@eecs.berkeley.edu, glider@google.com, dvyukov@google.com, corbet@lwn.net, alexios.zavras@intel.com, allison@lohutok.net, Anup.Patel@wdc.com, tglx@linutronix.de, gregkh@linuxfoundation.org, atish.patra@wdc.com, kstewart@linuxfoundation.org, linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org Subject: Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it. In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 17 Oct 2019, Andrey Ryabinin wrote: > On 10/8/19 9:11 AM, Nick Hu wrote: > > Skip the memmove checking for those archs who don't support it. > > The patch is fine but the changelog sounds misleading. We don't skip memmove checking. > If arch don't have memmove than the C implementation from lib/string.c used. > It's instrumented by compiler so it's checked and we simply don't need that KASAN's memmove with > manual checks. Thanks Andrey. Nick, could you please update the patch description? - Paul