From: Paul Walmsley <paul.walmsley@sifive.com>
To: Nick Hu <nickhu@andestech.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc: alankao@andestech.com, palmer@sifive.com, aou@eecs.berkeley.edu,
glider@google.com, dvyukov@google.com, corbet@lwn.net,
alexios.zavras@intel.com, allison@lohutok.net,
Anup.Patel@wdc.com, tglx@linutronix.de,
gregkh@linuxfoundation.org, atish.patra@wdc.com,
kstewart@linuxfoundation.org, linux-doc@vger.kernel.org,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
kasan-dev@googlegroups.com, linux-mm@kvack.org
Subject: Re: [PATCH v3 1/3] kasan: Archs don't check memmove if not support it.
Date: Thu, 17 Oct 2019 19:58:04 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.9999.1910171957310.3156@viisi.sifive.com> (raw)
In-Reply-To: <ba456776-a77f-5306-60ef-c19a4a8b3119@virtuozzo.com>
On Thu, 17 Oct 2019, Andrey Ryabinin wrote:
> On 10/8/19 9:11 AM, Nick Hu wrote:
> > Skip the memmove checking for those archs who don't support it.
>
> The patch is fine but the changelog sounds misleading. We don't skip memmove checking.
> If arch don't have memmove than the C implementation from lib/string.c used.
> It's instrumented by compiler so it's checked and we simply don't need that KASAN's memmove with
> manual checks.
Thanks Andrey. Nick, could you please update the patch description?
- Paul
next prev parent reply other threads:[~2019-10-18 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1570514544.git.nickhu@andestech.com>
[not found] ` <c9fa9eb25a5c0b1f733494dfd439f056c6e938fd.1570514544.git.nickhu@andestech.com>
2019-10-16 19:23 ` Palmer Dabbelt
2019-10-17 10:39 ` Andrey Ryabinin
2019-10-18 2:58 ` Paul Walmsley [this message]
[not found] ` <8d86d53e904bece0623cb8969cdc70f782fa2bae.1570514544.git.nickhu@andestech.com>
2019-10-21 9:33 ` [PATCH v3 2/3] riscv: Add KASAN support Greentime Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.9999.1910171957310.3156@viisi.sifive.com \
--to=paul.walmsley@sifive.com \
--cc=Anup.Patel@wdc.com \
--cc=alankao@andestech.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=aou@eecs.berkeley.edu \
--cc=aryabinin@virtuozzo.com \
--cc=atish.patra@wdc.com \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kasan-dev@googlegroups.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=nickhu@andestech.com \
--cc=palmer@sifive.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox