From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F396C433F5 for ; Sat, 5 Mar 2022 20:53:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A9D5C6B0071; Sat, 5 Mar 2022 15:53:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4C046B0072; Sat, 5 Mar 2022 15:53:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93B316B0073; Sat, 5 Mar 2022 15:53:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 832B06B0071 for ; Sat, 5 Mar 2022 15:53:49 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 4E74321546 for ; Sat, 5 Mar 2022 20:53:49 +0000 (UTC) X-FDA: 79211534178.11.7437835 Received: from angie.orcam.me.uk (angie.orcam.me.uk [78.133.224.34]) by imf05.hostedemail.com (Postfix) with ESMTP id E4F2B100003 for ; Sat, 5 Mar 2022 20:53:47 +0000 (UTC) Received: by angie.orcam.me.uk (Postfix, from userid 500) id 7ABCF92009C; Sat, 5 Mar 2022 21:53:45 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id 6C20D92009B; Sat, 5 Mar 2022 20:53:45 +0000 (GMT) Date: Sat, 5 Mar 2022 20:53:45 +0000 (GMT) From: "Maciej W. Rozycki" To: Mike Rapoport cc: Tiezhu Yang , Thomas Bogendoerfer , Andrew Morton , Xuefeng Li , linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/4] MIPS: Modify mem= and memmap= parameter In-Reply-To: Message-ID: References: <1646108941-27919-1-git-send-email-yangtiezhu@loongson.cn> <8956c625-c18d-846e-3e65-7920776b27f3@loongson.cn> <4e10d7a4-3b3e-a220-8cd2-565614288950@loongson.cn> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: o1qi8qewaiwuwerdrewkfewkgigg8t14 Authentication-Results: imf05.hostedemail.com; dkim=none; spf=none (imf05.hostedemail.com: domain of macro@orcam.me.uk has no SPF policy when checking 78.133.224.34) smtp.mailfrom=macro@orcam.me.uk; dmarc=none X-Rspamd-Queue-Id: E4F2B100003 X-HE-Tag: 1646513627-784430 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000034, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 5 Mar 2022, Maciej W. Rozycki wrote: > Also to say (in said commit): > > "There's no point to rewrite some logic to parse command line > to pass initrd parameters or to declare a user memory area. > We could use instead parse_early_param() that does the same > thing." > > is IMHO unfair given that the "rewrite" was there in place almost six > years before `parse_early_param' even started to exist! Why do people > assume things have always been like they see them at the time they look? Self-correction for an incorrect last-moment edit: four years before rather than six (`parse_early_param' went in upstream shortly before: ). Maciej