From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Mike Rapoport <rppt@kernel.org>
Cc: Tiezhu Yang <yangtiezhu@loongson.cn>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Andrew Morton <akpm@linux-foundation.org>,
Xuefeng Li <lixuefeng@loongson.cn>,
linux-mips@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/4] MIPS: Modify mem= and memmap= parameter
Date: Sat, 5 Mar 2022 20:53:45 +0000 (GMT) [thread overview]
Message-ID: <alpine.DEB.2.21.2203052047090.47558@angie.orcam.me.uk> (raw)
In-Reply-To: <alpine.DEB.2.21.2203051837280.47558@angie.orcam.me.uk>
On Sat, 5 Mar 2022, Maciej W. Rozycki wrote:
> Also to say (in said commit):
>
> "There's no point to rewrite some logic to parse command line
> to pass initrd parameters or to declare a user memory area.
> We could use instead parse_early_param() that does the same
> thing."
>
> is IMHO unfair given that the "rewrite" was there in place almost six
> years before `parse_early_param' even started to exist! Why do people
> assume things have always been like they see them at the time they look?
Self-correction for an incorrect last-moment edit: four years before
rather than six (`parse_early_param' went in upstream shortly before:
<https://git.kernel.org/pub/scm/linux/kernel/git/ralf/linux.git/commit/?id=5145764263ab>).
Maciej
prev parent reply other threads:[~2022-03-05 20:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 4:28 Tiezhu Yang
2022-03-01 4:28 ` [PATCH v4 1/4] MIPS: Refactor early_parse_mem() to fix mem= parameter Tiezhu Yang
2022-03-04 15:10 ` Thomas Bogendoerfer
2022-03-04 15:35 ` Thomas Bogendoerfer
2022-03-04 17:11 ` Maciej W. Rozycki
2022-03-05 13:13 ` Mike Rapoport
2022-03-07 16:29 ` Thomas Bogendoerfer
2022-03-07 22:07 ` Mike Rapoport
2022-03-07 23:09 ` Maciej W. Rozycki
2022-03-01 4:28 ` [PATCH v4 2/4] memblock: Introduce memblock_mem_range_remove_map() Tiezhu Yang
2022-03-01 4:29 ` [PATCH v4 3/4] MIPS: Refactor early_parse_memmap() to fix memmap= parameter Tiezhu Yang
2022-03-01 4:29 ` [PATCH v4 4/4] MIPS: Remove not used variable usermem Tiezhu Yang
2022-03-01 9:55 ` [PATCH v4 0/4] MIPS: Modify mem= and memmap= parameter Mike Rapoport
2022-03-01 11:51 ` Tiezhu Yang
2022-03-01 14:31 ` Mike Rapoport
2022-03-02 1:50 ` Tiezhu Yang
2022-03-02 8:03 ` Mike Rapoport
2022-03-02 9:28 ` Tiezhu Yang
2022-03-02 12:50 ` Mike Rapoport
2022-03-04 17:05 ` Maciej W. Rozycki
2022-03-05 6:19 ` Tiezhu Yang
2022-03-05 13:26 ` Mike Rapoport
2022-03-05 19:21 ` Maciej W. Rozycki
2022-03-05 20:09 ` Mike Rapoport
2022-03-06 1:22 ` Maciej W. Rozycki
2022-03-05 20:53 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2203052047090.47558@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lixuefeng@loongson.cn \
--cc=rppt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox