From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD95C433E0 for ; Sun, 7 Mar 2021 20:54:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 90A9064FF3 for ; Sun, 7 Mar 2021 20:54:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90A9064FF3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=orcam.me.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8140B6B0088; Sun, 7 Mar 2021 15:54:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C3B46B0089; Sun, 7 Mar 2021 15:54:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 68B3B6B008C; Sun, 7 Mar 2021 15:54:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 4A31B6B0088 for ; Sun, 7 Mar 2021 15:54:47 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 079E64427 for ; Sun, 7 Mar 2021 20:54:47 +0000 (UTC) X-FDA: 77894282214.16.CC3C98D Received: from angie.orcam.me.uk (angie.orcam.me.uk [157.25.102.26]) by imf04.hostedemail.com (Postfix) with ESMTP id 9AB3A3C3 for ; Sun, 7 Mar 2021 20:54:45 +0000 (UTC) Received: by angie.orcam.me.uk (Postfix, from userid 500) id EFA0692009D; Sun, 7 Mar 2021 21:54:43 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by angie.orcam.me.uk (Postfix) with ESMTP id E0A2C92009B; Sun, 7 Mar 2021 21:54:43 +0100 (CET) Date: Sun, 7 Mar 2021 21:54:43 +0100 (CET) From: "Maciej W. Rozycki" To: Huang Pei cc: Thomas Bogendoerfer , ambrosehua@gmail.com, Bibo Mao , Andrew Morton , linux-mips@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Jiaxun Yang , Paul Burton , Li Xuefeng , Yang Tiezhu , Gao Juxin , Fuxin Zhang , Huacai Chen Subject: Re: [PATCH] MIPS: clean up CONFIG_MIPS_PGD_C0_CONTEXT handling In-Reply-To: <20210305071322.srv5gv5sro5p4dll@ambrosehua-HP-xw6600-Workstation> Message-ID: References: <20210227061944.266415-1-huangpei@loongson.cn> <20210227061944.266415-2-huangpei@loongson.cn> <20210304010623.4tyzpzgllsdy3ssg@ambrosehua-HP-xw6600-Workstation> <20210305071322.srv5gv5sro5p4dll@ambrosehua-HP-xw6600-Workstation> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 9AB3A3C3 X-Stat-Signature: sp5sizmraksdku77wh6uknpyan9u8yg7 Received-SPF: none (orcam.me.uk>: No applicable sender policy available) receiver=imf04; identity=mailfrom; envelope-from=""; helo=angie.orcam.me.uk; client-ip=157.25.102.26 X-HE-DKIM-Result: none/none X-HE-Tag: 1615150485-993429 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 5 Mar 2021, Huang Pei wrote: > /home/hp/projects/Linux/temp/linux-stable/arch/mips/include/asm/io.h: I= n function =E2=80=98phys_to_virt=E2=80=99: > /home/hp/projects/Linux/temp/linux-stable/arch/mips/include/asm/io.h:12= 2:9: error: cast to pointer=20 > from integer of different size [-Werror=3Dint-to-pointer-cast] > return (void *)(address + PAGE_OFFSET - PHYS_OFFSET); >=20 >=20 > ......... >=20 > Only change CAC_BASE Does NOT work=20 Thank you for checking. Right. I don't know why it fails for `phys_to_virt' where `address' is=20 of the `unsigned long' type, but there are other places where the macros=20 themselves are cast to `void *'. We may want to rework that stuff, but=20 not necessarily on this occasion. Use an explicit cast of the macro to `s64' here then, as my other=20 suggestion was. Anything is better than hardcoded magic numbers. Maciej