From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 125F8C10DCE for ; Fri, 13 Mar 2020 21:43:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C897120663 for ; Fri, 13 Mar 2020 21:43:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pZQzsGh/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C897120663 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B8926B0003; Fri, 13 Mar 2020 17:43:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 569806B0006; Fri, 13 Mar 2020 17:43:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 430AD6B0007; Fri, 13 Mar 2020 17:43:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0051.hostedemail.com [216.40.44.51]) by kanga.kvack.org (Postfix) with ESMTP id 29B946B0003 for ; Fri, 13 Mar 2020 17:43:29 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BD4654DB5 for ; Fri, 13 Mar 2020 21:43:28 +0000 (UTC) X-FDA: 76591665696.29.match64_75a7e1d718e34 X-HE-Tag: match64_75a7e1d718e34 X-Filterd-Recvd-Size: 4408 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 13 Mar 2020 21:43:28 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id p14so6057943pfn.4 for ; Fri, 13 Mar 2020 14:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=SDNw5CeBEFA5vbuaWYRsJmiXk2Vn4f6I+fsRzDcDF5g=; b=pZQzsGh/c0WrWAiFM9UAZpHX38gUmWFqs+L7VOKADQYFP48cNV+2N6hSyfbbG/Pu4d twp6A7jNVhERqTTJ5pgz2tD8/ylTHXn0BFaHcWdrXF5ujuaE7tPCBLOgalpYgJL+gfvW p3BI9lLFF9I+Oy0T0+Tp10+CMuyBhahaFaQf56dY/SR40lJpiEBWd5cY4bFb7vHrn/MD Sw4ITSVRVoaM5PjQy6dJFJM7lxGDnV70uR3dqGKxi4v3ymoKHZo+c4PG+KVRruM8knLX 0Oz11Iq5/r4VcNXn0UFD6Ot+Bc8Jhpgk3FXSPFEEJ6o6Sjz5EHKbByKLqdRQICCh6mxc 1QBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=SDNw5CeBEFA5vbuaWYRsJmiXk2Vn4f6I+fsRzDcDF5g=; b=eQmZXEKeDgPdkS3eSWruJkz5MPwyQ+rEqFy9P8atouXvhRBKToODHS+VqtlIy/2yZp uRP/Fz+oG8pNpVvHXspDSKcTtF4m4yKUCYnMeFsie9YvHI+5+Rvbf8QzTMkO5ZvDuQ5D DIBk/K2J2CNCIiB39qAIrQaaTbiJfLhBFiAJIUHWPwGH73PJclAOwiXI3y4NOumqvne2 hGnSHjPXUd2nEPBLseX433Z832UMOvEZen1BBVyTGyVYGKytQXoRajvYjxCIDN4Flffw cRLchZ2lkSLkq0/HRpUxN+7sFTte1fS4nPsoYk6mXB2XQHF3H9sff39rfMZ/kyucHJNM basw== X-Gm-Message-State: ANhLgQ2wLRzJ6IItmQDVw+eHnoQiBv8XtO1G+AfAYJnbTt/epCUPRp7Q c1klKnzFSiG+5Hwdya7AaJtvwg== X-Google-Smtp-Source: ADFU+vs5HCuqq1xKRwirD0WhYDOW1scUjscD0l2RCmUOOn5TDpACKWyibD3zz0dfth/WUYXLVX/n7g== X-Received: by 2002:a62:7c15:: with SMTP id x21mr16494914pfc.132.1584135807311; Fri, 13 Mar 2020 14:43:27 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id z17sm11256310pff.12.2020.03.13.14.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Mar 2020 14:43:26 -0700 (PDT) Date: Fri, 13 Mar 2020 14:43:26 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Huang, Ying" cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Johannes Weiner , Michal Hocko , Dave Hansen , Mel Gorman , Vlastimil Babka , Minchan Kim , Hugh Dickins , Rik van Riel Subject: Re: [PATCH] mm: Code cleanup for MADV_FREE In-Reply-To: <20200313090056.2104105-1-ying.huang@intel.com> Message-ID: References: <20200313090056.2104105-1-ying.huang@intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 13 Mar 2020, Huang, Ying wrote: > From: Huang Ying > > Some comments for MADV_FREE is revised and added to help people understand the > MADV_FREE code, especially the page flag, PG_swapbacked. This makes > page_is_file_cache() isn't consistent with its comments. So the function is > renamed to page_is_file_lru() to make them consistent again. All these are put > in one patch as one logical change. > > Signed-off-by: "Huang, Ying" > Suggested-by: David Hildenbrand > Suggested-by: Johannes Weiner > Suggested-by: David Rientjes > Cc: Michal Hocko > Cc: Dave Hansen > Cc: Mel Gorman > Cc: Vlastimil Babka > Cc: Minchan Kim > Cc: Hugh Dickins > Cc: Rik van Riel Acked-by: David Rientjes Thanks very much for following through with this Ying!