From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1966C10F25 for ; Wed, 11 Mar 2020 05:08:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A86BE208C4 for ; Wed, 11 Mar 2020 05:08:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="G3nvp3iV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A86BE208C4 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3A6456B0003; Wed, 11 Mar 2020 01:08:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 356B96B0006; Wed, 11 Mar 2020 01:08:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 245596B0007; Wed, 11 Mar 2020 01:08:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 095BE6B0003 for ; Wed, 11 Mar 2020 01:08:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BC0BD45A3 for ; Wed, 11 Mar 2020 05:08:57 +0000 (UTC) X-FDA: 76581901914.19.step19_311cfc0b42a22 X-HE-Tag: step19_311cfc0b42a22 X-Filterd-Recvd-Size: 4674 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Mar 2020 05:08:57 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id b22so485031pls.12 for ; Tue, 10 Mar 2020 22:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=upcYox+hR0ff8PbXC/tjXbgIwJyTE9zI/gU5bKsBrcE=; b=G3nvp3iVpVC+yHQkmM1FUvj/OVrYCTe+/dsoBxZEEtfC1hTuasXwqna9yAt1P/K0nE 0ki9mJaOhcAhhTHguCjns0Wm6eO+AxFLXS+Khmi3iBUY27t+SCI8cOoDxJfy7Isd6fvX Mu/DS3uKKOBVRg7kWVV94+e+N2lKLD2uSlV/Zme8Gbpl/6C7QV1QrhNN41ylEOoRmBMS KVUowSNqsYyS9rRl4wDU2xUuVSWErgbs8GtxYB3DCQ6wTFvodblK0mEVkLf/TnNXM8Bo GnRLy/4G0dZ10SiSmYK7fQ8dkobJaCEEy62h0tlVic2Vlf3D2iB9CrdrPW4NKHlRaePG PCvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=upcYox+hR0ff8PbXC/tjXbgIwJyTE9zI/gU5bKsBrcE=; b=cOlt/cA01jUZPg9bSSeU6TtS/ENDFFFl+Np2pdPZlKdDly0C61Vo65WxvTYEbHdFMC jqbTHz7bzcTugPu510NoKKtJvwzZO7HZ8CKl3iE0aqPyhyUdR5/+f7v5Q3z8PO/AUFVH SYJ3lS/buuW6iiSRfk5ZeAH2F2O7ANY1bwAGq9homdplr0pPllOrZrp+XHMbq1/yOhwX VOB6QSFnlvAUs/OX5iQZufYOT+IxWP7sfcIFGy7KO9Cb6vPEsJqB12Ko+LuRYF2PK0ip rmwU6p9YTlpqcpX3Bzhp0DDzEZU4KptAogBjYNxNFVDPSJy6rcFJsaDm1cnwd7Uuxo0s INzQ== X-Gm-Message-State: ANhLgQ3fcKneaWje+7LklRVJUEwFEek7+yQBFgXdzLuwZ0giwH8tKlO8 3ZTV2Q6Ak849ws6+LIfqTHW2Xw== X-Google-Smtp-Source: ADFU+vuBKgQ7tqeX6Y2sfHE73I7Iho4eW+dmedne9Rn6L6zY1FrbOYgVjkUbkDyv3fB7rHslN4KxSg== X-Received: by 2002:a17:902:7794:: with SMTP id o20mr1418285pll.312.1583903335973; Tue, 10 Mar 2020 22:08:55 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id o128sm16053078pfg.5.2020.03.10.22.08.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 22:08:55 -0700 (PDT) Date: Tue, 10 Mar 2020 22:08:54 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Huang, Ying" cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Hildenbrand , Michal Hocko , Dave Hansen , Mel Gorman , Vlastimil Babka , Minchan Kim , Johannes Weiner , Hugh Dickins , Rik van Riel Subject: Re: [PATCH] mm: Add more comments for MADV_FREE In-Reply-To: <20200311011117.1656744-1-ying.huang@intel.com> Message-ID: References: <20200311011117.1656744-1-ying.huang@intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Mar 2020, Huang, Ying wrote: > diff --git a/include/linux/mm_inline.h b/include/linux/mm_inline.h > index 6f2fef7b0784..01144dd02a5f 100644 > --- a/include/linux/mm_inline.h > +++ b/include/linux/mm_inline.h > @@ -9,10 +9,11 @@ > * page_is_file_cache - should the page be on a file LRU or anon LRU? > * @page: the page to test > * > - * Returns 1 if @page is page cache page backed by a regular filesystem, > - * or 0 if @page is anonymous, tmpfs or otherwise ram or swap backed. > - * Used by functions that manipulate the LRU lists, to sort a page > - * onto the right LRU list. > + * Returns 1 if @page is page cache page backed by a regular filesystem or > + * anonymous page lazily freed (e.g. via MADV_FREE). Returns 0 if @page is > + * normal anonymous page, tmpfs or otherwise ram or swap backed. Used by > + * functions that manipulate the LRU lists, to sort a page onto the right LRU > + * list. The function name is misleading: anonymous pages that can be lazily freed are not file cache. This returns 1 because of the question it is asking: anonymous lazily freeable pages should be on the file lru, not the anon lru. So before adjusting the comment I'd suggest renaming the function to something like page_is_file_lru(). The rest looks fine.