From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85CACC10DCE for ; Fri, 6 Mar 2020 21:27:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3CD70206D7 for ; Fri, 6 Mar 2020 21:27:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BUhj7FUo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CD70206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CB7766B0005; Fri, 6 Mar 2020 16:27:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C68456B0006; Fri, 6 Mar 2020 16:27:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7D9A6B0007; Fri, 6 Mar 2020 16:27:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 9E7F26B0005 for ; Fri, 6 Mar 2020 16:27:54 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5C05C40F0 for ; Fri, 6 Mar 2020 21:27:54 +0000 (UTC) X-FDA: 76566224868.18.owl10_ac869643f309 X-HE-Tag: owl10_ac869643f309 X-Filterd-Recvd-Size: 4739 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Mar 2020 21:27:53 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id s8so1630663pjq.0 for ; Fri, 06 Mar 2020 13:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=C0VzUXVAs0KwQk2ex+LNFdy9kNQT2H0n7ipR3g6Roag=; b=BUhj7FUou0TJsOwEx6ONrXB1sekmtZSqO819dYogLqGfctQMqCmMPfrSjPHxFJYlGF oh+KLjeD+JQicByp6I4YjvohSnBLI467WClN0CdeJJGtjuRyMlTzzPBsjIfdwj9lUQh4 hGitKzXxMqv5/s7XHsPifAQJF0G+5iOt0tOw4k9bb6zsQRdYMYb0KNNMuxwbSlqDWhK3 BmZOG1xEEtSljmfun/Empcz3j8ajeXExAliYTJIXFo3n+rfVjnV+1rjL/voBYJtic3kW dt9LlNHd56fUvMOmmZ39p9BDiszfpR7OfczW3u0ydKORQ0i2TJspmOv2PwSfR/E6bREy TXSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=C0VzUXVAs0KwQk2ex+LNFdy9kNQT2H0n7ipR3g6Roag=; b=I0lhgzbDinlw3rW8L3/EATbqg7yecS0Zy7L45YOs9cofKrJcO8i0Xvx3qJu2OaqYuk yUZISieYZkWz7333BcMp/i5zVVZVbAX6K83U3m4P4D+SY/lj3WppvyOMSDfpFVTFuTWm zOyiFgfpBAM88rNXCSX1W/122bjeZrD+kNJSKs6VWIXW+WMwJxG33K5s8g5sfbLPZJi4 Ec66DG5WRGqULS+hr461712G9a8bfKwpuN+K4paxYXNq4scUItzEMwfAWtFfRGcavPmq xSPvgP3BOF4MdGqzyl0wG0YjOXoKT+c3nbAegGVmEd1bGYoYgyKUgWMdzQNZQmE8JLLi rbkw== X-Gm-Message-State: ANhLgQ0RnXfkW/MkxsMSNMGMsMoHJMQ2Bkaaidr77oz3ruKKtGMNsaRj 3LRjJvTeORIu99BI/GE9KcEvhA== X-Google-Smtp-Source: ADFU+vtsizdnHi84qmMKsek2u26+wR5vE2A0wbnhG6ZjbIZuDtumLM2crAg46sW5d0vDTU6DCQ8MKw== X-Received: by 2002:a17:90a:3ee5:: with SMTP id k92mr3974491pjc.81.1583530072599; Fri, 06 Mar 2020 13:27:52 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id x3sm10279826pjq.5.2020.03.06.13.27.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 13:27:51 -0800 (PST) Date: Fri, 6 Mar 2020 13:27:51 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Yang Shi cc: "Kirill A. Shutemov" , Andrew Morton , "Kirill A. Shutemov" , Mike Rapoport , Jeremy Cline , Linux Kernel Mailing List , Linux MM Subject: Re: [patch 1/2] mm, shmem: add thp fault alloc and fallback stats In-Reply-To: Message-ID: References: <20200220131202.i77zt3zj53mimrnu@box> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 6 Mar 2020, Yang Shi wrote: > > > > I think we can choose to either include file allocations into both > > > > thp_fault_alloc and thp_fault_fallback or we can exclude them from both of > > > > them. I don't think we can account for only one of them. > > > > > > How's about the 3rd option, adding THP_FILE_FALLBACK. > > > > I like this option. > > > > Problem with THP_FAULT_* is that shmem_getpage_gfp() is called not only > > from fault path, but also from syscalls. > > I found another usecase for THP_FILE_FALLBACK. I wanted to measure > file THP allocation success rate in our uecase. It looks nr_file_alloc > / (nr_file_alloc + nr_file_fallback) is the most simple way. > > David, are you still working on this patch? > Yes, I have a refresh to send out. I don't enable CONFIG_FS_DAX but the THP_FAULT_FALLBACK there seems somewhat out of place. It's not necessarily within the scope of my patchset but thought I'd mention it if someone had strong feelings about whether the DAX cases should be separated out as well.