From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E796C10DCE for ; Fri, 6 Mar 2020 20:41:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 05AA9206CC for ; Fri, 6 Mar 2020 20:41:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="B3cs7k1/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 05AA9206CC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8E3736B000A; Fri, 6 Mar 2020 15:41:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86CD46B000C; Fri, 6 Mar 2020 15:41:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 75AC06B000D; Fri, 6 Mar 2020 15:41:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 5AB966B000A for ; Fri, 6 Mar 2020 15:41:36 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 224BC1EE6 for ; Fri, 6 Mar 2020 20:41:36 +0000 (UTC) X-FDA: 76566108192.07.rod35_2b0c4f8a96747 X-HE-Tag: rod35_2b0c4f8a96747 X-Filterd-Recvd-Size: 4166 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 6 Mar 2020 20:41:35 +0000 (UTC) Received: by mail-pl1-f178.google.com with SMTP id d9so1334052plo.11 for ; Fri, 06 Mar 2020 12:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=yKGKapuUKILEkemnrbPssWUGiqebVX3yxGAYmrDS0Sg=; b=B3cs7k1/pc/ZT6R0YkOqeR/COPust1J58A0q4JvjPIJmnA5mqdan1WT3Oi+jBKHIZj F5Mwj0aJKIc30RjRue2vWDtOFkFsGuoRcTyGv5/NcKRndUsykBSqfjCDdzhUWQUpW6c2 RwGw2xSl+y0hVTPcJ11srTPOSOOmoJpWvLgEk9gkpz+m4VwSpI/FGW3eEIQPWyJdhUGR vBwn/KLTBojdpHoTufUudUxq6zr0bLih2tquszsygTjbcA91HPkJ10WH4tYrDTcM5Dzw vtAzWaWenEZcU3NrBiYCNeE+Hkrdo2Egh1Zfx7L/41inETAYdEXr3TCWRlCyfihyRpai qTsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=yKGKapuUKILEkemnrbPssWUGiqebVX3yxGAYmrDS0Sg=; b=trVPmQ3bxMi39+JQhyKUkxlMgFxsed4iNLP/PM1LqLj9YOQ48txZvcUxd4mFT72o+d qQpZAXNh0SZy5O23djXDAPsMh3I6orXsHb1vm3paMtc9thwUEzki1+Ta3EWCK+SZlnwG B3NbOZumcJGCJc+HImw6TuD435l3OmzHJx7qn3MXRHiUSUYmQ627LAW4pGA/+AhuezgF lDhokq3WYG5iJdWkqbjMW05PddS4uK67b+cDrLbkrVbAHBFK56TCmK7VG7qSSfNkWU+p J3kMeIoPCFTX+rVGR2cIzzBhVZJwy98VeBZzeRO5CbXxtDwR8YRBl/kCsbWmb25dWg80 Dkrg== X-Gm-Message-State: ANhLgQ2jdhql3ZrVFHFYnSW630zhmOgqR/vOjcL+EeyWDLcRvNvCYUQL xNiPQN2cKBjsr9Gn2br0vwFBDQ== X-Google-Smtp-Source: ADFU+vuBtlgASi4ldRcAREIzD+j0WNer4alYi/qGIzeiUCbMBirI9Tn1xqYZVv+jcSitQSUy/qcOig== X-Received: by 2002:a17:90a:608:: with SMTP id j8mr5243607pjj.85.1583527294240; Fri, 06 Mar 2020 12:41:34 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id m9sm3252334pga.92.2020.03.06.12.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2020 12:41:33 -0800 (PST) Date: Fri, 6 Mar 2020 12:41:32 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Huang, Ying" cc: David Hildenbrand , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Hansen , Mel Gorman , Vlastimil Babka , Zi Yan , Michal Hocko , Peter Zijlstra , Minchan Kim , Johannes Weiner , Hugh Dickins Subject: Re: [PATCH -V2] mm: Add PageLayzyFree() helper functions for MADV_FREE In-Reply-To: <87y2sf1ki1.fsf@yhuang-dev.intel.com> Message-ID: References: <20200304081732.563536-1-ying.huang@intel.com> <87y2sf1ki1.fsf@yhuang-dev.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 5 Mar 2020, Huang, Ying wrote: > > In general, I don't think this patch really improves the situation ... > > it's only a handful of places where this change slightly makes the code > > easier to understand. And there, only slightly ... I'd prefer better > > comments instead (e.g., in PageAnon()), documenting what it means for a > > anon page to either have PageSwapBacked() set or not. > > Personally, I still prefer the better named functions than the comments > here and there. But I can understand that people may have different > flavor. > Maybe add a comment to page-flags.h referring to what PageSwapBacked indicates when PageAnon is true?