From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC138C4BA1E for ; Wed, 26 Feb 2020 18:26:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 951BB20714 for ; Wed, 26 Feb 2020 18:26:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 951BB20714 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 39C7F6B0070; Wed, 26 Feb 2020 13:26:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34D756B0071; Wed, 26 Feb 2020 13:26:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 262136B0073; Wed, 26 Feb 2020 13:26:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 0CFED6B0070 for ; Wed, 26 Feb 2020 13:26:35 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id ED7C74404 for ; Wed, 26 Feb 2020 18:26:34 +0000 (UTC) X-FDA: 76533108708.30.glove36_5684e2dc4cf4c X-HE-Tag: glove36_5684e2dc4cf4c X-Filterd-Recvd-Size: 1490 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 18:26:34 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id D85853EC05; Wed, 26 Feb 2020 18:26:33 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id D78BD3EC04; Wed, 26 Feb 2020 18:26:33 +0000 (UTC) Date: Wed, 26 Feb 2020 18:26:33 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Vlastimil Babka cc: qiwuchen55@gmail.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, linux-mm@kvack.org, chenqiwu Subject: Re: [PATCH] mm/slub.c: replace cpu_slab->partial with wrapped APIs In-Reply-To: <94b29ab3-3789-a9b7-0a66-0acfaef6ca9f@suse.cz> Message-ID: References: <1581951895-3038-1-git-send-email-qiwuchen55@gmail.com> <94b29ab3-3789-a9b7-0a66-0acfaef6ca9f@suse.cz> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 26 Feb 2020, Vlastimil Babka wrote: > Same comment as for "[PATCH v2] mm/slub.c: replace kmem_cache->cpu_partial with > wrapped APIs". This function generates code only with CONFIG_SLUB_CPU_PARTIAL > and so the wrapper just obfuscates the code unnecessarily. I agree. Lets drop this.