From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E058C4BA09 for ; Wed, 26 Feb 2020 01:32:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 389F421744 for ; Wed, 26 Feb 2020 01:32:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="cMZyruXs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 389F421744 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C61FE6B0003; Tue, 25 Feb 2020 20:32:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C11E46B0005; Tue, 25 Feb 2020 20:32:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00856B0006; Tue, 25 Feb 2020 20:32:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0201.hostedemail.com [216.40.44.201]) by kanga.kvack.org (Postfix) with ESMTP id 954E96B0003 for ; Tue, 25 Feb 2020 20:32:29 -0500 (EST) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6F5AC248C for ; Wed, 26 Feb 2020 01:32:29 +0000 (UTC) X-FDA: 76530553218.23.train09_6d0137d8f0940 X-HE-Tag: train09_6d0137d8f0940 X-Filterd-Recvd-Size: 4437 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 26 Feb 2020 01:32:28 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id y5so533790pfb.11 for ; Tue, 25 Feb 2020 17:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=QGVoInCNmu8ZzMYmZXdTHXHi+j3WLOo8+btiFix0h28=; b=cMZyruXsJf+pGUh7iEAlG5NywteERqKsrsx7J98svJV4/9Xln+d/iie6kpru3zcKvS yw3R+sEA8r5MvMBbXohJ62LLc4RH5VrOHVvWumGNwBAxozyFDkVpFiV0uOf9lSsck96W ohLXDCKiarMkJZbreViNDGewyU7jADg1d+A3tgr/naBCpgrvY49Q8UI2GXDSUngtRdOr k6YoeVSo4i/U52qxoDvgpeSy/SjQPGAvaip4bQn6110e0L6iRSiTsbtxjFEl+gVn7rrT lhDdSj05O2eCngCrgUvJcdHlpWVc3vwqPA+HwWgFhWAQo3if9YK9MuhJT1//L4wi9tI4 t2sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=QGVoInCNmu8ZzMYmZXdTHXHi+j3WLOo8+btiFix0h28=; b=VLWyskYo2johwSCCSSeM8UJ/oG0Ym+D3im1m6At3I2sl3timrzu3GfU2pWlLPkcG0y L9XLvdKQwuHOHx6I4Bz6A5HN+8azyVNvLr71RZt5d2xQbJ5jqcYV071nzvOwuDwMk3DA 48OZLn5MJWJrws1BNL7klnNWiTzsAuGmNjCDXXAuKOWPtzLKNEhvbO1x9dZjPXLJaKip mbY9WvS9AUYfVrDQmMA6S7P4bL03ohjO7f+vHCcliVnNS9Dfwz7X0lLmQohjP7hCULOH D0XQVEdq2ukJUURHUoXEHCfYROlhmbFy/Kh1XaBxhVmRuwDIQBxgJO28nkOHqqNZ9oAN mIxQ== X-Gm-Message-State: APjAAAUC53pXEHNkBAqtnfKe2ZAkxGgJ7qgQxS/z4DmfnK8qMAO6ivtp l+tBOUFGxKg9rvRqpD655K52ZQ== X-Google-Smtp-Source: APXvYqw5igQcRBjvwdMbNMWg7/TudhemJKHFEauczrz/uXC69lZrRHVFe5sstpLf5F0sd3qHQFlC5g== X-Received: by 2002:a62:16d0:: with SMTP id 199mr1643753pfw.96.1582680747619; Tue, 25 Feb 2020 17:32:27 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id b3sm349178pfr.88.2020.02.25.17.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Feb 2020 17:32:25 -0800 (PST) Date: Tue, 25 Feb 2020 17:32:24 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Mel Gorman cc: Andrew Morton , Michal Hocko , Vlastimil Babka , Ivan Babrou , Rik van Riel , Linux-MM , Linux Kernel Mailing List Subject: Re: [PATCH 2/3] mm, page_alloc: Disable watermark boosting if THP is disabled at boot In-Reply-To: <20200225141534.5044-3-mgorman@techsingularity.net> Message-ID: References: <20200225141534.5044-1-mgorman@techsingularity.net> <20200225141534.5044-3-mgorman@techsingularity.net> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 Feb 2020, Mel Gorman wrote: > Watermark boosting is intended to increase the success rate and reduce > latency of high-order allocations, particularly THP. If THP is disabled > at boot, then it makes sense to disable watermark boosting as well. While > there are other high-order allocations that potentially benefit, they > are relatively rare. > > Signed-off-by: Mel Gorman > --- > mm/huge_memory.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b08b199f9a11..565bb9973ff8 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -472,6 +472,7 @@ static int __init setup_transparent_hugepage(char *str) > &transparent_hugepage_flags); > clear_bit(TRANSPARENT_HUGEPAGE_REQ_MADV_FLAG, > &transparent_hugepage_flags); > + disable_watermark_boosting(); > ret = 1; > } > out: Seems like watermark boosting can help prevent fragmentation so it benefits all hugepage sized allocations for the long term and that would include dynamic provisioning of hugetlb memory or hugetlb overcommit?