From: David Rientjes <rientjes@google.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mike Rapoport <rppt@linux.ibm.com>,
Jeremy Cline <jcline@redhat.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, thp: track fallbacks due to failed memcg charges separately
Date: Tue, 18 Feb 2020 17:59:24 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.2002181758480.108053@chino.kir.corp.google.com> (raw)
In-Reply-To: <20200218082632.kn5ouiditzx5h2iq@box>
On Tue, 18 Feb 2020, Kirill A. Shutemov wrote:
> On Mon, Feb 17, 2020 at 09:41:40PM -0800, David Rientjes wrote:
> > The thp_fault_fallback stat in either /proc/vmstat is incremented if
> > either the hugepage allocation fails through the page allocator or the
> > hugepage charge fails through mem cgroup.
> >
> > This patch leaves this field untouched but adds a new field,
> > thp_fault_fallback_charge, which is incremented only when the mem cgroup
> > charge fails.
> >
> > This distinguishes between faults that want to be backed by hugepages but
> > fail due to fragmentation (or low memory conditions) and those that fail
> > due to mem cgroup limits. That can be used to determine the impact of
> > fragmentation on the system by excluding faults that failed due to memcg
> > usage.
> >
> > Signed-off-by: David Rientjes <rientjes@google.com>
>
> The patch looks good to me, but I noticed that we miss THP_FAULT_FALLBACK
> (and THP_FAULT_FALLBACK_CHARGE) accounting in shmem_getpage_gfp().
>
> Could you fix this while you are there?
Sure, I'll add it as a predecessor and also count THP_FAULT_ALLOC for
consistency.
next prev parent reply other threads:[~2020-02-19 1:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 5:41 David Rientjes
2020-02-18 8:26 ` Kirill A. Shutemov
2020-02-19 1:59 ` David Rientjes [this message]
2020-02-18 9:34 ` Mike Rapoport
2020-02-19 2:29 ` [patch 1/2] mm, shmem: add thp fault alloc and fallback stats David Rientjes
2020-02-19 2:29 ` [patch 2/2] mm, thp: track fallbacks due to failed memcg charges separately David Rientjes
2020-02-19 8:23 ` Mike Rapoport
2020-02-19 3:22 ` [patch 1/2] mm, shmem: add thp fault alloc and fallback stats Yang Shi
2020-02-19 3:44 ` David Rientjes
2020-02-19 17:01 ` Yang Shi
2020-02-20 13:12 ` Kirill A. Shutemov
2020-03-06 17:23 ` Yang Shi
2020-03-06 21:27 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2002181758480.108053@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=jcline@redhat.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox