From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62E3DC7619B for ; Sun, 16 Feb 2020 01:29:10 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 27CE92084E for ; Sun, 16 Feb 2020 01:29:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UT5y7eB2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 27CE92084E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A7B9F6B0007; Sat, 15 Feb 2020 20:29:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A2AF56B0008; Sat, 15 Feb 2020 20:29:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 940356B000A; Sat, 15 Feb 2020 20:29:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0081.hostedemail.com [216.40.44.81]) by kanga.kvack.org (Postfix) with ESMTP id 797726B0007 for ; Sat, 15 Feb 2020 20:29:09 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 2E418180AD811 for ; Sun, 16 Feb 2020 01:29:09 +0000 (UTC) X-FDA: 76494256818.27.sail54_4fde613b9d804 X-HE-Tag: sail54_4fde613b9d804 X-Filterd-Recvd-Size: 4165 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Sun, 16 Feb 2020 01:29:08 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id j15so7151604pgm.6 for ; Sat, 15 Feb 2020 17:29:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=vFO8RYQ8FlPE3NMfWDMQg3z8BnL2LFOQ1aCp2wNf0j0=; b=UT5y7eB27mtmBLa9qTJY5GoNQuboQGZtdwfzReReOwUaVVOzs3n/h9Ba5B4+RntXCc W1HLiL5YMb1prRJyisKY/4AyutIk6MxcInq+taUJe61ASvIaUoTX0W1yeVlJTkr2L0yy Z3GZggc+OUPDOdBhQ0DJ6Ykh4gvxbTjTWcMManFakBmoxbGTXMvJ4M3UFkEjFGElSKiK eN1DWddOuAh6EgdiDyjMRu2QKSwZyN8l5Lyk1v5HDOtCCBbEl0Zg2qdgq3RGqYmGsGq0 tHcRjJPPPzpU9hR1e2942b2sR9rjzicAMAJmllqUTzPah+NVj/FQiWIRoWMnJmEdNM/l 7h5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=vFO8RYQ8FlPE3NMfWDMQg3z8BnL2LFOQ1aCp2wNf0j0=; b=f/b6U+s5eyf2MNF9MiB1H9xozYXta7ZbhgomA1wGCrQpJZjjJYHGnbPJByXL+coG13 XLhR5pkKO74/d/BDcMiNgkFyXyfSlMyij31xYKXudApEx1GcUcSG9b3fYnIyL4H9q6UZ aRpRTeJQIBWGn9Qsj/RMHGyJhntzHAXdikjm+K25KZ7O/1uKE2iWnFMPh0iXbiCNUPDv CrYhZupwZ2KDRrQ85oGJIhDpejQa6wmBU2AZDPuysuNbKfFscP4eA2GPZ8Vu2b8R3b38 TDZv6c3q9aDd8vxw6Y1qJC4Bh/N8Bh/ZuOnXqPe5YcZKcXAkwncf12zJSFRBrr8R75/k sVGQ== X-Gm-Message-State: APjAAAXMKn0x1k/TUgkRiH0S7V1UjXhleupXm5bzz/bmfpO1pC8J4Z+a YLDF0C2hFReRz5Qgfa2579FUYQ== X-Google-Smtp-Source: APXvYqwGtSe01CE+gnuMCStuNLDGVUiWBZr15rIhWthJ0+0xS/XrZRM8r+yOoO8qXDDTI8pRQqw/Sw== X-Received: by 2002:a63:e4d:: with SMTP id 13mr10841291pgo.343.1581816547399; Sat, 15 Feb 2020 17:29:07 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id b98sm11853084pjc.16.2020.02.15.17.29.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Feb 2020 17:29:06 -0800 (PST) Date: Sat, 15 Feb 2020 17:29:06 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Mina Almasry cc: mike.kravetz@oracle.com, shuah@kernel.org, shakeelb@google.com, gthelen@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v12 5/9] hugetlb_cgroup: add accounting for shared mappings In-Reply-To: <20200211213128.73302-5-almasrymina@google.com> Message-ID: References: <20200211213128.73302-1-almasrymina@google.com> <20200211213128.73302-5-almasrymina@google.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 11 Feb 2020, Mina Almasry wrote: > For shared mappings, the pointer to the hugetlb_cgroup to uncharge lives > in the resv_map entries, in file_region->reservation_counter. > > After a call to region_chg, we charge the approprate hugetlb_cgroup, and if > successful, we pass on the hugetlb_cgroup info to a follow up region_add call. > When a file_region entry is added to the resv_map via region_add, we put the > pointer to that cgroup in file_region->reservation_counter. If charging doesn't > succeed, we report the error to the caller, so that the kernel fails the > reservation. > > On region_del, which is when the hugetlb memory is unreserved, we also uncharge > the file_region->reservation_counter. > > Signed-off-by: Mina Almasry > Does this develop a dependency on hugetlb_cgroup.h in hugetlb.h? Or maybe we only need a forward declaration of struct file_region there?