From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04AC8C2D0DB for ; Wed, 29 Jan 2020 21:00:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A35A520716 for ; Wed, 29 Jan 2020 21:00:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gO1MuPCC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A35A520716 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DDD636B0297; Wed, 29 Jan 2020 16:00:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D8EB26B0298; Wed, 29 Jan 2020 16:00:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA43F6B0299; Wed, 29 Jan 2020 16:00:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0171.hostedemail.com [216.40.44.171]) by kanga.kvack.org (Postfix) with ESMTP id B45C16B0297 for ; Wed, 29 Jan 2020 16:00:19 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 5F4234821 for ; Wed, 29 Jan 2020 21:00:19 +0000 (UTC) X-FDA: 76431889758.15.trick61_5a14ed2269513 X-HE-Tag: trick61_5a14ed2269513 X-Filterd-Recvd-Size: 4490 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Jan 2020 21:00:18 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id d5so319241pjz.5 for ; Wed, 29 Jan 2020 13:00:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=mMHj7VQFJ/ru51SSc9JWwA5eIS4YpdouqCmEJIqSD3s=; b=gO1MuPCCzwJo6EXl1niF9Nc6Pd0XCURfNhJmEtuV0mF/2PRgvb2nXlZ62BvLzbgPoJ /x315s7W8W6TGg1qsy73Xm1Ujmx5N5x95A6L3xwbMJ5yzCz3tQv0+qN1xm+ac1uvJ3qi oq6FQIEde4mQG6wOn36dCV1T6iCQS7C10HI7Q0zEWfHyRrLwKycChsZC9pCTeFOK/XgS MLxk35KrU1T1sWDXMp3CHH2kJRQex6cDy2WqUJfkbYKhBWRmVrIhPTxQnYjpUQzrzjtf qKIm5qzhJMeVt9kj4Ugt4QQYIaUGtoOTXRQDvinBq0xHktYy+sMx//j60z5CIZEFB73T pTyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=mMHj7VQFJ/ru51SSc9JWwA5eIS4YpdouqCmEJIqSD3s=; b=F35T9umaqSYzPO6UUEJqNApmTC0e5WaXpxxCBQqvxAk/P3MTUhskljRe4B7ihvb2Kc OQT5PXsYTfWxizIjVAxc4eXG+qdjFcC3gzk8fHFfZR1fOZ/QPm9jmCm0IdCOVQWJ7wA+ kPGFjUk4yS8kG9Cij+UmeCgclUb/f/fPyNdhsgJKvovTV6MT0sK5p0i6A36kCRlc2OfZ nwQHNP/DV1kjPqHc3aqjQFksmO6aTUG4RZAZiCo1nHHXQvblYFzZdUUEv6jvT96+auA7 qS8LI0kkk6uFVedO57UuoGjEkld4TcbAIE+mLr01w4xyyvzLjaUHC/5Pc/cWQuqREx11 0SYg== X-Gm-Message-State: APjAAAU/TBJOsYeI3CrrOq3+j+Mz2kRP69J66Bvys0Wp6ArDzU/+HdA8 et5vJYAyZbb5y6GrSBA8vng+HQ== X-Google-Smtp-Source: APXvYqwwsgYkaH1FxmcBL16bgFwn1K3P9bSw/X5rfK8KXL1891FWdD3zVJE8MVHT+EKF+0rVog6gng== X-Received: by 2002:a17:902:264:: with SMTP id 91mr1284534plc.335.1580331617669; Wed, 29 Jan 2020 13:00:17 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id z18sm3730466pfk.19.2020.01.29.13.00.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 13:00:17 -0800 (PST) Date: Wed, 29 Jan 2020 13:00:16 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Sandipan Das cc: Mina Almasry , mike.kravetz@oracle.com, shakeelb@google.com, shuah@kernel.org, gthelen@google.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, cgroups@vger.kernel.org, aneesh.kumar@linux.vnet.ibm.com Subject: Re: [PATCH v10 7/8] hugetlb_cgroup: Add hugetlb_cgroup reservation tests In-Reply-To: <7ce6d59f-fd73-c529-2ad6-edda9937966d@linux.ibm.com> Message-ID: References: <20200115012651.228058-1-almasrymina@google.com> <20200115012651.228058-7-almasrymina@google.com> <7ce6d59f-fd73-c529-2ad6-edda9937966d@linux.ibm.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 23 Jan 2020, Sandipan Das wrote: > > The tests use both shared and private mapped hugetlb memory, and > > monitors the hugetlb usage counter as well as the hugetlb reservation > > counter. They test different configurations such as hugetlb memory usage > > via hugetlbfs, or MAP_HUGETLB, or shmget/shmat, and with and without > > MAP_POPULATE. > > > > Also add test for hugetlb reservation reparenting, since this is > > a subtle issue. > > > > Signed-off-by: Mina Almasry > > > > For powerpc64, either 16MB/16GB or 2MB/1GB huge pages are supported depending > on the MMU type (Hash or Radix). I was just running these tests on a powerpc64 > system with Hash MMU and ran into problems because the tests assume that the > hugepage size is always 2MB. Can you determine the huge page size at runtime? > I assume this is only testing failures of the tools/testing/selftests additions that hardcode 2MB paths and not a kernel problem? In other words, you can still boot, reserve, alloc, and free hugetlb pages on ppc after this patchset without using the selftests?