From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0752C33CB7 for ; Sun, 19 Jan 2020 22:07:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7CB9B208CD for ; Sun, 19 Jan 2020 22:07:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Htb8a7DQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CB9B208CD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 025EB6B058C; Sun, 19 Jan 2020 17:07:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF1A26B058D; Sun, 19 Jan 2020 17:07:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE1246B058E; Sun, 19 Jan 2020 17:07:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id C51D26B058C for ; Sun, 19 Jan 2020 17:07:50 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id A2BDA33C4 for ; Sun, 19 Jan 2020 22:07:50 +0000 (UTC) X-FDA: 76395771900.20.hot10_618a807bc2a3e X-HE-Tag: hot10_618a807bc2a3e X-Filterd-Recvd-Size: 3478 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Jan 2020 22:07:50 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id t14so4357833plr.8 for ; Sun, 19 Jan 2020 14:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=/hL29TjD11NGp8Ljf9rHQ0/AomEN8AOZ3o3x8TsgXFk=; b=Htb8a7DQKkL06WtZXoCSnCOkhCYVkwPXtAjHrfTT4Xf/VJ7nmB6lqnfWKNBWwhtOS3 siqlOUsxdP8pNvX68Wd1JyIArmQdGVKeeaqGXGHBnTRBjNnc8aCDLm1rl9WvpmeKx/Pj QopS5fa0Wg1ErVLFS6THufGI7FsHFbapGRaFomm+XycZKqMzdZm/OJuBOnyPp7Wf0nQE En/g4tVfelYvlC+Y8w9P9YCoe/9zOAkU3xct1fPfoQwy8JP0pUXHmioI7m94tgNchdEt /qaA/zvDDagxoYQ7uAx2SQtsfeG6IOBrkr4O7YrZwCKAhnagumI5u15CBCCBeV2Si05a DNOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=/hL29TjD11NGp8Ljf9rHQ0/AomEN8AOZ3o3x8TsgXFk=; b=aSLfEM5SraSHDEe+NuwD6JyGa4oSY3OTUAmFFFg0k7Fx8zxHZgWxA33bKiGV4rf465 9bzpban08M5sRobEbmUY+pqzh+L9PNW5VPHACbx9yzuIMgWimhyFpfjzn2vlCA6usQTY T9ggc+/9maqvyCu5+LjPAXT0Lz1ufOTxp+xdPUNYQSN+S1ElDIApmbvRQl+TXlSXXt8U B/wOsNw/FcNejgSznMOd+PvxsarkmBQEorHL1eoGoyvfrD9txxhbTRW8pL0qHMPB8L6/ N0ptco0+T4eK8r6iz8ouziHvEVhn6+XGTIR20b/Bw4XMJocUEJxcGzZ1mWm4UBEPCKfO Wp+w== X-Gm-Message-State: APjAAAWdp45BKuFXbS48RYWc32ENMVoI8/8vaTtB44B4gDWdCG7RflqZ ZlGlxz97PFYOqUbSjArU3n2P6w== X-Google-Smtp-Source: APXvYqy3TwdlfQVbRBki8jvV+Ha5LEu15W292YWV3lv0kmcreU2NGVrJBpZ3J28RMy/c6CpAjCfdzQ== X-Received: by 2002:a17:90a:cf07:: with SMTP id h7mr19741769pju.66.1579471669229; Sun, 19 Jan 2020 14:07:49 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id p17sm35685755pfn.31.2020.01.19.14.07.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jan 2020 14:07:48 -0800 (PST) Date: Sun, 19 Jan 2020 14:07:48 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Wei Yang cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison In-Reply-To: <20200119131408.23247-5-richardw.yang@linux.intel.com> Message-ID: References: <20200119131408.23247-1-richardw.yang@linux.intel.com> <20200119131408.23247-5-richardw.yang@linux.intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.001886, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 19 Jan 2020, Wei Yang wrote: > Since function returns directly, bad_[reason|flags] is not used any > where. > > This is a following cleanup for commit e570f56cccd21 ("mm: > check_new_page_bad() directly returns in __PG_HWPOISON case") > > Signed-off-by: Wei Yang Acked-by: David Rientjes