From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A312BC2D0C6 for ; Wed, 11 Dec 2019 21:44:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6671620836 for ; Wed, 11 Dec 2019 21:44:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="eQhg4POU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6671620836 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F11B56B3413; Wed, 11 Dec 2019 16:44:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EC1BD6B3414; Wed, 11 Dec 2019 16:44:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD71A6B3415; Wed, 11 Dec 2019 16:44:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0112.hostedemail.com [216.40.44.112]) by kanga.kvack.org (Postfix) with ESMTP id C6BCA6B3413 for ; Wed, 11 Dec 2019 16:44:46 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 7CEDF246E for ; Wed, 11 Dec 2019 21:44:46 +0000 (UTC) X-FDA: 76254190572.14.word89_63d1c3868a440 X-HE-Tag: word89_63d1c3868a440 X-Filterd-Recvd-Size: 4336 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by imf24.hostedemail.com (Postfix) with ESMTP for ; Wed, 11 Dec 2019 21:44:45 +0000 (UTC) Received: by mail-pf1-f193.google.com with SMTP id q8so2452275pfh.7 for ; Wed, 11 Dec 2019 13:44:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=wkoNjmei5sIfxNKYIytd7zHyeLv+b+a83ECcT+r0WWE=; b=eQhg4POUvSGfKDGmAfB3LhOnH9J0IJrxgIKZW7BGANMGUuByHKI+JnZLshJIG0WwcC V5XHdW9lyQ0MxV4oCh5vmk6QOnMheyWSd7MtrBaQHzvG2phA2M+va7PryK+uMB/BaSC1 JVWjqwGDON2r046aP2D7HY9T/KlpEDvS7obk3LFAZSBSudOxMJvscBD73p+L02Li55xF dmlNUnmolqzRBTmLtafIo/dt1oBuYT5nyE2kXVQNrbWoaowAaA5J+QAgxVr49uGPT8sR AaOoPPhahDkiwf2miU8uH2JKMezkJfZyWM0/ojhYFkbC62EPJia6RoaCK0Oy74n9WXMU zJLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=wkoNjmei5sIfxNKYIytd7zHyeLv+b+a83ECcT+r0WWE=; b=mnj6RmiTgrzIQb+nhd531SsNjYTn6jW6ZRwiN+SfeCW8fdqls+ZAGAor8hYSPHX4O3 jV4NbjrOgyU71CmRnManIwzMKqrsUa+VA1k41ceGtegDr8OfAVFY+uAnbCPoBfUE5ER5 auFfXM58aRqoI+nTdmAlwm49Y0dHKYtpRUjHKPRKuugFdTKxyZehSXQdtTZoMyiPAHm+ iOYeufvE5eRD/Bpsfumy0Pp++yH4Hm92vTwSEZRUYnv9ygUmlA7j6SgPUJ/JQY+zoELj u7RvgsqCoVjOVvQPVuWsKEaFRvTCwa2C+gWVaRIlnNBpDOGsPxntXmrVuIv/KRCw6xtU 6mWA== X-Gm-Message-State: APjAAAUShFXXj9gv/CXWA107hfQtFZRq3NZdra7nSiPCov1b8X+5EFAY kVqR63J9PlATGcBNfgVE7IkalA== X-Google-Smtp-Source: APXvYqw05tLSLBYBI71/bzNSgwOhxYrohKf19gPgNhSmYuZNKVWRhCaiynvJ1ckIYvm66/35qDD51Q== X-Received: by 2002:a62:7541:: with SMTP id q62mr6091794pfc.256.1576100684673; Wed, 11 Dec 2019 13:44:44 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id y38sm3951314pgk.33.2019.12.11.13.44.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Dec 2019 13:44:43 -0800 (PST) Date: Wed, 11 Dec 2019 13:44:43 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Ilya Dryomov cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Edward Chron , Michal Hocko , Andrew Morton , Linus Torvalds Subject: Re: [PATCH] mm/oom: fix pgtables units mismatch in Killed process message In-Reply-To: <20191211202830.1600-1-idryomov@gmail.com> Message-ID: References: <20191211202830.1600-1-idryomov@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 11 Dec 2019, Ilya Dryomov wrote: > pr_err() expects kB, but mm_pgtables_bytes() returns the number of > bytes. As everything else is printed in kB, I chose to fix the value > rather than the string. > > Before: > > [ pid ] uid tgid total_vm rss pgtables_bytes swapents oom_score_adj name > ... > [ 1878] 1000 1878 217253 151144 1269760 0 0 python > ... > Out of memory: Killed process 1878 (python) total-vm:869012kB, anon-rss:604572kB, file-rss:4kB, shmem-rss:0kB, UID:1000 pgtables:1269760kB oom_score_adj:0 > > After: > > [ pid ] uid tgid total_vm rss pgtables_bytes swapents oom_score_adj name > ... > [ 1436] 1000 1436 217253 151890 1294336 0 0 python > ... > Out of memory: Killed process 1436 (python) total-vm:869012kB, anon-rss:607516kB, file-rss:44kB, shmem-rss:0kB, UID:1000 pgtables:1264kB oom_score_adj:0 > > Fixes: 70cb6d267790 ("mm/oom: add oom_score_adj and pgtables to Killed process message") > Signed-off-by: Ilya Dryomov Acked-by: David Rientjes I'd also suggest a Cc: stable@vger.kernel.org # 5.4