From: David Rientjes <rientjes@google.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Edward Chron <echron@arista.com>, Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] mm/oom: fix pgtables units mismatch in Killed process message
Date: Wed, 11 Dec 2019 13:44:43 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.1912111343050.97034@chino.kir.corp.google.com> (raw)
In-Reply-To: <20191211202830.1600-1-idryomov@gmail.com>
On Wed, 11 Dec 2019, Ilya Dryomov wrote:
> pr_err() expects kB, but mm_pgtables_bytes() returns the number of
> bytes. As everything else is printed in kB, I chose to fix the value
> rather than the string.
>
> Before:
>
> [ pid ] uid tgid total_vm rss pgtables_bytes swapents oom_score_adj name
> ...
> [ 1878] 1000 1878 217253 151144 1269760 0 0 python
> ...
> Out of memory: Killed process 1878 (python) total-vm:869012kB, anon-rss:604572kB, file-rss:4kB, shmem-rss:0kB, UID:1000 pgtables:1269760kB oom_score_adj:0
>
> After:
>
> [ pid ] uid tgid total_vm rss pgtables_bytes swapents oom_score_adj name
> ...
> [ 1436] 1000 1436 217253 151890 1294336 0 0 python
> ...
> Out of memory: Killed process 1436 (python) total-vm:869012kB, anon-rss:607516kB, file-rss:44kB, shmem-rss:0kB, UID:1000 pgtables:1264kB oom_score_adj:0
>
> Fixes: 70cb6d267790 ("mm/oom: add oom_score_adj and pgtables to Killed process message")
> Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Acked-by: David Rientjes <rientjes@google.com>
I'd also suggest a
Cc: stable@vger.kernel.org # 5.4
next prev parent reply other threads:[~2019-12-11 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 20:28 Ilya Dryomov
2019-12-11 21:44 ` David Rientjes [this message]
2019-12-12 10:41 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1912111343050.97034@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=echron@arista.com \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox