From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21A0AC3F68F for ; Thu, 5 Dec 2019 19:45:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EBAEE224F8 for ; Thu, 5 Dec 2019 19:45:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EBAEE224F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8896C6B11E4; Thu, 5 Dec 2019 14:45:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 839FA6B11E5; Thu, 5 Dec 2019 14:45:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 776DC6B11E6; Thu, 5 Dec 2019 14:45:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 65D496B11E4 for ; Thu, 5 Dec 2019 14:45:50 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 1A991180AD815 for ; Thu, 5 Dec 2019 19:45:50 +0000 (UTC) X-FDA: 76232118060.25.low61_15cd0970c6e1b X-HE-Tag: low61_15cd0970c6e1b X-Filterd-Recvd-Size: 1858 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Thu, 5 Dec 2019 19:45:49 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id 4909D3EBB9; Thu, 5 Dec 2019 19:45:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 46EA23E95C; Thu, 5 Dec 2019 19:45:49 +0000 (UTC) Date: Thu, 5 Dec 2019 19:45:49 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Yang Shi cc: fabecassis@nvidia.com, jhubbard@nvidia.com, mhocko@suse.com, vbabka@suse.cz, mgorman@techsingularity.net, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [v3 PATCH] mm: move_pages: return valid node id in status if the page is already on the target node In-Reply-To: <1575572053-128363-1-git-send-email-yang.shi@linux.alibaba.com> Message-ID: References: <1575572053-128363-1-git-send-email-yang.shi@linux.alibaba.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000055, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 6 Dec 2019, Yang Shi wrote: > Felix Abecassis reports move_pages() would return random status if the > pages are already on the target node by the below test program: Looks ok. Acked-by: Christoph Lameter Nitpicks: > @@ -1553,7 +1555,7 @@ static int add_page_for_migration(struct mm_struct *mm, unsigned long addr, > if (PageHuge(page)) { > if (PageHead(page)) { > isolate_huge_page(page, pagelist); > - err = 0; > + err = 1; Add a meaningful constant instead of 1? > out: > up_read(&mm->mmap_sem); > + > return err; Dont do that.