From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B83B3C5DF60 for ; Thu, 7 Nov 2019 20:48:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 77A70222CD for ; Thu, 7 Nov 2019 20:48:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Db4tHNgn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77A70222CD Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC8536B0003; Thu, 7 Nov 2019 15:48:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E78E06B0006; Thu, 7 Nov 2019 15:48:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D69CE6B0007; Thu, 7 Nov 2019 15:48:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0050.hostedemail.com [216.40.44.50]) by kanga.kvack.org (Postfix) with ESMTP id BF66B6B0003 for ; Thu, 7 Nov 2019 15:48:12 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 6FC0982499A8 for ; Thu, 7 Nov 2019 20:48:12 +0000 (UTC) X-FDA: 76130668824.02.grip54_64b661706a33f X-HE-Tag: grip54_64b661706a33f X-Filterd-Recvd-Size: 4316 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 7 Nov 2019 20:48:11 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id l4so2379820plt.13 for ; Thu, 07 Nov 2019 12:48:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=JwhsjFXL+RY1sUbjvE8fwB+ZL/JKNehRxoaYrePu9kQ=; b=Db4tHNgnwbiKUQQBjTMR0BNEUAL8a5ipvo2TbmNtUEJbzAu8RlKa6uhhd5aFftsQ0T F4kd7FDyZGOMI1Jn2Ady7sMtkff3mQU5vj21YIKxUIDWe3mzZA+e2X3wS6qaGGdo2h6j CROaJhOezoBE5fyBtHxs0z4+m6jtUiaouXO/grqPU5yi+nh4h0QkiXgnwZyOQo7Wu/NY PtN954C/mOUI18lQP053JcZVOAXNb6cMnHnnYCvkt/1qKusp5e3xS3DJ7Z3zaUHYNncM JA0jxdur16ge7pCLtb7FNHEzIT9TyQAV4U/oSnXGprSYOEtFh4UYNhj/re2T87B6uuwZ CFvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=JwhsjFXL+RY1sUbjvE8fwB+ZL/JKNehRxoaYrePu9kQ=; b=l+4kGrHWxjVrzH/xPCzrR6zVj1n83kxu+sM/R+Z8dwr+uPeUWEXcQcwtYuy9Bx76u6 M+qk9H68LGK4iSWTeAA1yZptiwr1n0Oeiafi7b2H53RTgYSjBaUZkK50pjFy+3y0Xue7 /f2L0q5QTStJ6OJrbZZ+GFUdrprhy0dMwY5wFPAUmy8D0nCsgea00BRWX/8LObVCuKFu DTonp+awD1AekORXh/mAkrt2vPZzskbo3Qraxx0WzE6d7zgZuH/XPSEXHutrx8ZDwZe2 C9gIAhuhV+XQja6XyEXRQYHLSZ4jP7JB/mH2xQ7notaWfW1w/rJfNtaL1ZR4hRvynoYw Y4oQ== X-Gm-Message-State: APjAAAU2vdFzoni+adGZAUCMGOgw3CbhByjeNdpcZc4k+JyUPJIVaZYk davqjO0gWbHkxTlsWRxtsC3TDw== X-Google-Smtp-Source: APXvYqykdvTfDCqsSkkatuk30iFz3oWiBFqclYZEG2RhpWyX/ON1ggWyaHVSkpa526VjHZaUu3CQ4w== X-Received: by 2002:a17:902:a508:: with SMTP id s8mr5955147plq.26.1573159690626; Thu, 07 Nov 2019 12:48:10 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id h9sm4965652pjh.8.2019.11.07.12.48.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 12:48:09 -0800 (PST) Date: Thu, 7 Nov 2019 12:48:09 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Yunfeng Ye cc: akpm@linux-foundation.org, jgg@ziepe.ca, mhocko@suse.com, jglisse@redhat.com, minchan@kernel.org, peterz@infradead.org, jack@suse.cz, rppt@linux.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "hushiyuan@huawei.com" , "linfeilong@huawei.com" Subject: Re: [PATCH] mm/madvise: replace with page_size() in madvise_inject_error() In-Reply-To: <7296c9ca-f8a7-f31b-d090-cc6bf5ee1df4@huawei.com> Message-ID: References: <29dce60c-38d6-0220-f292-e298f0c78c4d@huawei.com> <7296c9ca-f8a7-f31b-d090-cc6bf5ee1df4@huawei.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 7 Nov 2019, Yunfeng Ye wrote: > >> The function page_size() is supported after the commit a50b854e073c > >> ("mm: introduce page_size()"). > >> > >> Replace with page_size() in madvise_inject_error() for readability. > >> > >> Signed-off-by: Yunfeng Ye > >> --- > >> mm/madvise.c | 8 ++++---- > >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> > >> diff --git a/mm/madvise.c b/mm/madvise.c > >> index 2be9f3fdb05e..38c4e7fcf850 100644 > >> --- a/mm/madvise.c > >> +++ b/mm/madvise.c > >> @@ -856,13 +856,13 @@ static int madvise_inject_error(int behavior, > >> { > >> struct page *page; > >> struct zone *zone; > >> - unsigned int order; > >> + unsigned int size; > > > > Should be unsinged long. > > > ok, thanks. Andrew has already help me modify the patch and add to -mm tree. > Good deal, in that case: Acked-by: David Rientjes