From: David Rientjes <rientjes@google.com>
To: Laura Abbott <labbott@redhat.com>
Cc: Alexander Potapenko <glider@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Kees Cook <keescook@chromium.org>,
clipos@ssi.gouv.fr, Vlastimil Babka <vbabka@suse.cz>,
Thibaut Sautereau <thibaut.sautereau@clip-os.org>
Subject: Re: [PATCH] mm: slub: Really fix slab walking for init_on_free
Date: Thu, 7 Nov 2019 12:44:54 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.1911071244410.88963@chino.kir.corp.google.com> (raw)
In-Reply-To: <20191106222208.26815-1-labbott@redhat.com>
On Wed, 6 Nov 2019, Laura Abbott wrote:
> Commit 1b7e816fc80e ("mm: slub: Fix slab walking for init_on_free")
> fixed one problem with the slab walking but missed a key detail:
> When walking the list, the head and tail pointers need to be updated
> since we end up reversing the list as a result. Without doing this,
> bulk free is broken. One way this is exposed is a NULL pointer with
> slub_debug=F:
>
> =============================================================================
> BUG skbuff_head_cache (Tainted: G T): Object already free
> -----------------------------------------------------------------------------
>
> INFO: Slab 0x000000000d2d2f8f objects=16 used=3 fp=0x0000000064309071 flags=0x3fff00000000201
> BUG: kernel NULL pointer dereference, address: 0000000000000000
> PGD 0 P4D 0
> Oops: 0000 [#1] PREEMPT SMP PTI
> CPU: 0 PID: 0 Comm: swapper/0 Tainted: G B T 5.3.8 #1
> Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015
> RIP: 0010:print_trailer+0x70/0x1d5
> Code: 28 4d 8b 4d 00 4d 8b 45 20 81 e2 ff 7f 00 00 e8 86 ce ef ff 8b 4b 20 48 89 ea 48 89 ee 4c 29 e2 48 c7 c7 90 6f d4 89 48 01 e9 <48> 33 09 48 33 8b 70 01 00 00 e8 61 ce ef ff f6 43 09 04 74 35 8b
> RSP: 0018:ffffbf7680003d58 EFLAGS: 00010046
> RAX: 000000000000005d RBX: ffffa3d2bb08e540 RCX: 0000000000000000
> RDX: 00005c2d8fdc2000 RSI: 0000000000000000 RDI: ffffffff89d46f90
> RBP: 0000000000000000 R08: 0000000000000242 R09: 000000000000006c
> R10: 0000000000000000 R11: 0000000000000030 R12: ffffa3d27023e000
> R13: fffff11080c08f80 R14: ffffa3d2bb047a80 R15: 0000000000000002
> FS: 0000000000000000(0000) GS:ffffa3d2be400000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: 0000000000000000 CR3: 000000007a6c4000 CR4: 00000000000006f0
> Call Trace:
> <IRQ>
> free_debug_processing.cold.37+0xc9/0x149
> ? __kfree_skb_flush+0x30/0x40
> ? __kfree_skb_flush+0x30/0x40
> __slab_free+0x22a/0x3d0
> ? tcp_wfree+0x2a/0x140
> ? __sock_wfree+0x1b/0x30
> kmem_cache_free_bulk+0x415/0x420
> ? __kfree_skb_flush+0x30/0x40
> __kfree_skb_flush+0x30/0x40
> net_rx_action+0x2dd/0x480
> __do_softirq+0xf0/0x246
> irq_exit+0x93/0xb0
> do_IRQ+0xa0/0x110
> common_interrupt+0xf/0xf
> </IRQ>
>
> Given we're now almost identical to the existing debugging
> code which correctly walks the list, combine with that.
>
> Link: https://lkml.kernel.org/r/20191104170303.GA50361@gandi.net
> Reported-by: Thibaut Sautereau <thibaut.sautereau@clip-os.org>
> Fixes: 1b7e816fc80e ("mm: slub: Fix slab walking for init_on_free")
> Signed-off-by: Laura Abbott <labbott@redhat.com>
Acked-by: David Rientjes <rientjes@google.com>
prev parent reply other threads:[~2019-11-07 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 22:22 Laura Abbott
2019-11-07 11:15 ` Alexander Potapenko
2019-11-07 20:44 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911071244410.88963@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=clipos@ssi.gouv.fr \
--cc=davem@davemloft.net \
--cc=glider@google.com \
--cc=keescook@chromium.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=thibaut.sautereau@clip-os.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox