From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5A68C5DF65 for ; Wed, 6 Nov 2019 21:28:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 502AF2166E for ; Wed, 6 Nov 2019 21:28:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="sbLfgdAS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 502AF2166E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B924C6B0003; Wed, 6 Nov 2019 16:28:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B41706B0006; Wed, 6 Nov 2019 16:28:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A56976B0007; Wed, 6 Nov 2019 16:28:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 92B476B0003 for ; Wed, 6 Nov 2019 16:28:15 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 1FE66181AEF09 for ; Wed, 6 Nov 2019 21:28:15 +0000 (UTC) X-FDA: 76127140950.18.pipe19_6517d7270bf0d X-HE-Tag: pipe19_6517d7270bf0d X-Filterd-Recvd-Size: 4652 Received: from mail-pf1-f194.google.com (mail-pf1-f194.google.com [209.85.210.194]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 Nov 2019 21:28:14 +0000 (UTC) Received: by mail-pf1-f194.google.com with SMTP id v19so13879pfm.3 for ; Wed, 06 Nov 2019 13:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=krzOUvpi1e5/wmoRaiU4lZEs6DtCOLGJs0yJ4n3NiT4=; b=sbLfgdAS6EOV//l2R1R1T6k78DSCdQF5xOe10EZQffA6kEO8JX0b9A6OzeFmsYBnoC 23KagORrktTZpPVwwaCyV1orBrqH+flbaUSwFmG/Na4NbuUuK8d8E1yPR3ke00MkQpDm vFsu6+fRKoUkbD3ObCzkSvrz6TmMUisT8ALkgNTBj/csrl0GuHqKje8O63ZnL1wSi8y9 v27nd3z2u4OiwuIrfffOp5Tg0s2umO4xYWoioIeKCoupHnWl2h8psosdgZI2drwsz39Z us48CeWvOT/4/BvzO++HlV6lrdgm2x91NM9tq03NQkAef3CskGnb9I1sp3ww3M74m+9U T14A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=krzOUvpi1e5/wmoRaiU4lZEs6DtCOLGJs0yJ4n3NiT4=; b=XFA57aaeAigNGs9+p+FfK0LJS7CQwD5Lp1tqs2L8clOs5jXibXW+InLUzCy+rAJ2rc uSyKN95G2kuuo1r86ZKyVjYDmzE0YqkQmpI5XL7qah64Cqf4XeY9SaWJCfNL/wkLUTuj ohlv5d9dh6vaZIclkeywBGjY3v0GZbVS6R7PHqOJVYpWDZIaC5Fksgg0wnsxY0zEEHxc Jy0Ht8cEMXuB8p3FEwfmw+EBmZg1jk9Mz4sImShc4+sWvsBbb5KRfedPa+3YqI2zJ0Pd 6rHwtNajOD7MG/0SgKRVssbmAk1dcRQ8a2WN7uJKwGernw8wfxCg4b/g/kFxnpkvgOLa 8Gbw== X-Gm-Message-State: APjAAAXywOxzKI7PJy0JDerxh6D5C3NqjMArLeEv7+Sp/dh6hkNJnA2N cEB2nMqpzJO+EeaYsm/6kaXN2g== X-Google-Smtp-Source: APXvYqz+40bL+/jMKwtbZTq0yAFSPXCohqQNWq9mFOR9X2C86UIGFQu+gwoKF6HXipUBEL6uRjY0yw== X-Received: by 2002:a62:180a:: with SMTP id 10mr6155357pfy.40.1573075693388; Wed, 06 Nov 2019 13:28:13 -0800 (PST) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id y138sm26034618pfb.174.2019.11.06.13.28.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Nov 2019 13:28:12 -0800 (PST) Date: Wed, 6 Nov 2019 13:28:11 -0800 (PST) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Yunfeng Ye cc: akpm@linux-foundation.org, jgg@ziepe.ca, mhocko@suse.com, jglisse@redhat.com, minchan@kernel.org, peterz@infradead.org, jack@suse.cz, rppt@linux.ibm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, "hushiyuan@huawei.com" , "linfeilong@huawei.com" Subject: Re: [PATCH] mm/madvise: replace with page_size() in madvise_inject_error() In-Reply-To: <29dce60c-38d6-0220-f292-e298f0c78c4d@huawei.com> Message-ID: References: <29dce60c-38d6-0220-f292-e298f0c78c4d@huawei.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 6 Nov 2019, Yunfeng Ye wrote: > The function page_size() is supported after the commit a50b854e073c > ("mm: introduce page_size()"). > > Replace with page_size() in madvise_inject_error() for readability. > > Signed-off-by: Yunfeng Ye > --- > mm/madvise.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/madvise.c b/mm/madvise.c > index 2be9f3fdb05e..38c4e7fcf850 100644 > --- a/mm/madvise.c > +++ b/mm/madvise.c > @@ -856,13 +856,13 @@ static int madvise_inject_error(int behavior, > { > struct page *page; > struct zone *zone; > - unsigned int order; > + unsigned int size; Should be unsinged long. > > if (!capable(CAP_SYS_ADMIN)) > return -EPERM; > > > - for (; start < end; start += PAGE_SIZE << order) { > + for (; start < end; start += size) { > unsigned long pfn; > int ret; > > @@ -874,9 +874,9 @@ static int madvise_inject_error(int behavior, > /* > * When soft offlining hugepages, after migrating the page > * we dissolve it, therefore in the second loop "page" will > - * no longer be a compound page, and order will be 0. > + * no longer be a compound page. > */ > - order = compound_order(compound_head(page)); > + size = page_size(compound_head(page)); > > if (PageHWPoison(page)) { > put_page(page);