From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C225ECA9ED1 for ; Sat, 2 Nov 2019 23:53:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 61FFC204EC for ; Sat, 2 Nov 2019 23:53:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oyQ4/6ZG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61FFC204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BFC8A6B0005; Sat, 2 Nov 2019 19:53:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BACE36B0006; Sat, 2 Nov 2019 19:53:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AC3746B0007; Sat, 2 Nov 2019 19:53:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 93A286B0005 for ; Sat, 2 Nov 2019 19:53:13 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 193BD5820 for ; Sat, 2 Nov 2019 23:53:13 +0000 (UTC) X-FDA: 76112991066.29.magic22_735c5261dd70c X-HE-Tag: magic22_735c5261dd70c X-Filterd-Recvd-Size: 4245 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Sat, 2 Nov 2019 23:53:12 +0000 (UTC) Received: by mail-pf1-f196.google.com with SMTP id c184so9593497pfb.0 for ; Sat, 02 Nov 2019 16:53:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=/Y/HsfG3BX2fZgofwl16a0Nv3tLsdVHznmMwpL2tAbQ=; b=oyQ4/6ZGtCXkWWsCVtzR159cLW781RxnGfJsxQT0yAE2AzURerN+9QEP8q57c7wQGK n0QPnE09l1qr7sAOafSgQC77zbAVWpiGjPP6bfmarhBVF1rjiY+hcF3gwFaYouTn6t5S xTWVNf5FC/jBtQqnOZG4Md6Z8vZgCRgWDDsh9KBGSptGyZjRMFkB7aKaJnLXFqcUH6SH ZQyDGV7+WhSqvhSiKUae1JgDhwpxN1rAKY1b4yNDyW908pORomuWwf/BEIDanBZGSVR0 efl/seYA0vCLlO7wEHE/cQ4FpUFsfylzhUkb8cCQZ0F6XOlbuHbaJHHn66672mi4GIHA vaUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=/Y/HsfG3BX2fZgofwl16a0Nv3tLsdVHznmMwpL2tAbQ=; b=hooOY6a46c6EiftJi94zpP5IonUYECCJFkSmjHGG0vMk3NUWgAExZvuSdTPlPq9XkP vkK0j8ucEBQK2a4RFPWucnIZqREntQvH/jIrYoutZj6st/+WFGLXypMiiXXwz/T13zAV EeUrvTLlz4ayPFzklOAu33ICSveZlDFTIDf0P4aeFRjeVlbjsZqzFvK6FU3R4O/GgzZF zcfiC9pPeSJQYvJWd+TDaIjoqd8FvHLv3TxRf3Cb4KT4rghXzlMOBjPQmcuxKb6PzDj2 yf5EbjbWloS4fCedIvdFlKgH5ir5Id4ksqRzgvpoyWakCnx/SgETIF0INSAGsKduGYCc OgQw== X-Gm-Message-State: APjAAAXGj/pE2XYCD2+qQpFrQLyibbYTeWCX1l8cSefi6lRvuiMqIjxS HWQphT5P3X2RnGTvNGkc0DM+6A== X-Google-Smtp-Source: APXvYqwp7XxCVtJH9Wu/z/Wo+cj9o3ZWUxHqgwaac9zlw6e8ka5CbJL81DheDVXkwtyyZR7JQcDr5A== X-Received: by 2002:a63:6786:: with SMTP id b128mr7272604pgc.126.1572738791143; Sat, 02 Nov 2019 16:53:11 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id bb15sm12364965pjb.22.2019.11.02.16.53.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Nov 2019 16:53:10 -0700 (PDT) Date: Sat, 2 Nov 2019 16:53:09 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Matthew Wilcox , Johannes Weiner cc: hui yang , Andrew Morton , mhocko@suse.com, dan.j.williams@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: There should have an unit (kB) In-Reply-To: <20191102205411.GB15832@bombadil.infradead.org> Message-ID: References: <1572704287-4444-1-git-send-email-yanghui.def@gmail.com> <20191102205411.GB15832@bombadil.infradead.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 2 Nov 2019, Matthew Wilcox wrote: > On Sat, Nov 02, 2019 at 10:18:07PM +0800, hui yang wrote: > > From: YangHui > > > > - printk(KERN_CONT " %ld", zone->lowmem_reserve[i]); > > + printk(KERN_CONT " %ldkB", zone->lowmem_reserve[i]); > > Make it look more perfect > > I don't think this is accounted in kilobytes though. Isn't it the > number of pages? > Yes, it's not in KB. Speaking of lowmem_reserve, however, the current default of 1/256 for both ZONE_DMA and ZONE_DMA32 seem too large as memory capacities of nodes increase. We tune this to be much smaller so that we don't have as much memory set aside only for GFP_DMA or GFP_DMA32 allocations for that reason and because there is less reliance on lowmem for our configurations. I'm wondering if the default should either be 1/256 up to a bounded memory capacity and then the excess is disregarded or whether the default itself should be changed to, say, 1024. Looping in Johannes who may also have an opinion on this.