From: David Rientjes <rientjes@google.com>
To: Matthew Wilcox <willy@infradead.org>,
Johannes Weiner <hannes@cmpxchg.org>
Cc: hui yang <yanghui.def@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
mhocko@suse.com, dan.j.williams@intel.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: There should have an unit (kB)
Date: Sat, 2 Nov 2019 16:53:09 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1911021646240.34229@chino.kir.corp.google.com> (raw)
In-Reply-To: <20191102205411.GB15832@bombadil.infradead.org>
On Sat, 2 Nov 2019, Matthew Wilcox wrote:
> On Sat, Nov 02, 2019 at 10:18:07PM +0800, hui yang wrote:
> > From: YangHui <yanghui.def@gmail.com>
> >
> > - printk(KERN_CONT " %ld", zone->lowmem_reserve[i]);
> > + printk(KERN_CONT " %ldkB", zone->lowmem_reserve[i]);
> > Make it look more perfect
>
> I don't think this is accounted in kilobytes though. Isn't it the
> number of pages?
>
Yes, it's not in KB.
Speaking of lowmem_reserve, however, the current default of 1/256 for both
ZONE_DMA and ZONE_DMA32 seem too large as memory capacities of nodes
increase. We tune this to be much smaller so that we don't have as much
memory set aside only for GFP_DMA or GFP_DMA32 allocations for that reason
and because there is less reliance on lowmem for our configurations.
I'm wondering if the default should either be 1/256 up to a bounded memory
capacity and then the excess is disregarded or whether the default itself
should be changed to, say, 1024.
Looping in Johannes who may also have an opinion on this.
prev parent reply other threads:[~2019-11-02 23:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 14:18 hui yang
2019-11-02 20:54 ` Matthew Wilcox
2019-11-02 23:53 ` David Rientjes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911021646240.34229@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=willy@infradead.org \
--cc=yanghui.def@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox