From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C550CCA9EAF for ; Mon, 21 Oct 2019 18:09:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D9FC20873 for ; Mon, 21 Oct 2019 18:09:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D9FC20873 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 52D586B0005; Mon, 21 Oct 2019 14:09:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DDF46B0006; Mon, 21 Oct 2019 14:09:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3F5046B0007; Mon, 21 Oct 2019 14:09:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0085.hostedemail.com [216.40.44.85]) by kanga.kvack.org (Postfix) with ESMTP id 1D6036B0005 for ; Mon, 21 Oct 2019 14:09:04 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id AFB8C52B3 for ; Mon, 21 Oct 2019 18:09:03 +0000 (UTC) X-FDA: 76068578166.12.size32_31f9bcf3d5315 X-HE-Tag: size32_31f9bcf3d5315 X-Filterd-Recvd-Size: 1850 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Oct 2019 18:09:03 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id A09753EEDA; Mon, 21 Oct 2019 18:09:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 9FC4D3E9BF; Mon, 21 Oct 2019 18:09:02 +0000 (UTC) Date: Mon, 21 Oct 2019 18:09:02 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Roman Gushchin cc: "linux-mm@kvack.org" , Michal Hocko , Johannes Weiner , "linux-kernel@vger.kernel.org" , Kernel Team , Shakeel Butt , Vladimir Davydov , Waiman Long Subject: Re: [PATCH 02/16] mm: vmstat: use s32 for vm_node_stat_diff in struct per_cpu_nodestat In-Reply-To: <20191021011550.GA8869@castle> Message-ID: References: <20191018002820.307763-1-guro@fb.com> <20191018002820.307763-3-guro@fb.com> <20191021011550.GA8869@castle> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 21 Oct 2019, Roman Gushchin wrote: > Sp far I haven't noticed any regression on the set of workloads where I did test > the patchset, but if you know any benchmark or realistic test which can affected > by this check, I'll be happy to try. > > Also, less-than-word-sized operations can be slower on some platforms. The main issue in the past was the cache footprint. Memory is slow. Processors are fast.