From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D8DC10F14 for ; Tue, 8 Oct 2019 19:06:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E11F8217D7 for ; Tue, 8 Oct 2019 19:06:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E11F8217D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 954368E0006; Tue, 8 Oct 2019 15:06:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DD888E0003; Tue, 8 Oct 2019 15:06:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F3A08E0006; Tue, 8 Oct 2019 15:06:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id 5FBEF8E0003 for ; Tue, 8 Oct 2019 15:06:58 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 1906462C0 for ; Tue, 8 Oct 2019 19:06:58 +0000 (UTC) X-FDA: 76021549716.30.sail41_59e716e36ab61 X-HE-Tag: sail41_59e716e36ab61 X-Filterd-Recvd-Size: 1639 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Tue, 8 Oct 2019 19:06:57 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id 0EC6A3EC01; Tue, 8 Oct 2019 19:06:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 0BD213E886; Tue, 8 Oct 2019 19:06:57 +0000 (UTC) Date: Tue, 8 Oct 2019 19:06:57 +0000 (UTC) From: Christopher Lameter X-X-Sender: cl@www.lameter.com To: Kaitao Cheng cc: akpm@linux-foundation.org, sashal@kernel.org, mhocko@suse.com, osalvador@suse.de, mgorman@techsingularity.net, rppt@linux.ibm.com, dan.j.williams@intel.com, alexander.h.duyck@linux.intel.com, pavel.tatashin@microsoft.com, glider@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: Re: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists() In-Reply-To: <20190927161416.62293-1-pilgrimtao@gmail.com> Message-ID: References: <20190927161416.62293-1-pilgrimtao@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 28 Sep 2019, Kaitao Cheng wrote: > There is no need to make the 'node_order' variable static > since new value always be assigned before use it. In the past MAX_NUMMNODES could become quite large like 512 or 1k. Large array allocations on the stack are problematic. Maybe that is no longer the case?