From: Christopher Lameter <cl@linux.com>
To: Kaitao Cheng <pilgrimtao@gmail.com>
Cc: akpm@linux-foundation.org, sashal@kernel.org, mhocko@suse.com,
osalvador@suse.de, mgorman@techsingularity.net,
rppt@linux.ibm.com, dan.j.williams@intel.com,
alexander.h.duyck@linux.intel.com, pavel.tatashin@microsoft.com,
glider@google.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Muchun Song <smuchun@gmail.com>
Subject: Re: [PATCH] mm, page_alloc: drop pointless static qualifier in build_zonelists()
Date: Tue, 8 Oct 2019 19:06:57 +0000 (UTC) [thread overview]
Message-ID: <alpine.DEB.2.21.1910081906120.4398@www.lameter.com> (raw)
In-Reply-To: <20190927161416.62293-1-pilgrimtao@gmail.com>
On Sat, 28 Sep 2019, Kaitao Cheng wrote:
> There is no need to make the 'node_order' variable static
> since new value always be assigned before use it.
In the past MAX_NUMMNODES could become quite large like 512 or 1k. Large
array allocations on the stack are problematic.
Maybe that is no longer the case?
next prev parent reply other threads:[~2019-10-08 19:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-27 16:14 Kaitao Cheng
2019-09-27 19:32 ` Dan Williams
2019-10-08 19:06 ` Christopher Lameter [this message]
2019-10-08 19:21 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910081906120.4398@www.lameter.com \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pavel.tatashin@microsoft.com \
--cc=pilgrimtao@gmail.com \
--cc=rppt@linux.ibm.com \
--cc=sashal@kernel.org \
--cc=smuchun@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox