From: David Rientjes <rientjes@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
tglx@linutronix.de, Enrico Weigelt <info@metux.net>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm, vmpressure: Fix a signedness bug in vmpressure_register_event()
Date: Thu, 26 Sep 2019 12:04:42 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1909261204300.39830@chino.kir.corp.google.com> (raw)
In-Reply-To: <20190925110449.GO3264@mwanda>
On Wed, 25 Sep 2019, Dan Carpenter wrote:
> The "mode" and "level" variables are enums and in this context GCC will
> treat them as unsigned ints so the error handling is never triggered.
>
> I also removed the bogus initializer because it isn't required any more
> and it's sort of confusing.
>
> Fixes: 3cadfa2b9497 ("mm/vmpressure.c: convert to use match_string() helper")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2019-09-26 19:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 11:04 Dan Carpenter
2019-09-25 13:07 ` Andy Shevchenko
2019-09-26 19:04 ` David Rientjes [this message]
2019-09-28 21:23 ` Andrew Morton
2019-09-28 21:47 ` Matthew Wilcox
2019-09-28 22:04 ` Andrew Morton
2019-10-01 7:20 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1909261204300.39830@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=info@metux.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox