From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54EDDC432C1 for ; Tue, 24 Sep 2019 20:55:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1C4AF207FD for ; Tue, 24 Sep 2019 20:55:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C4AF207FD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B7F8A6B000A; Tue, 24 Sep 2019 16:55:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2CF46B000C; Tue, 24 Sep 2019 16:55:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A42476B000D; Tue, 24 Sep 2019 16:55:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 7BD2B6B000A for ; Tue, 24 Sep 2019 16:55:03 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 1CEB252AA for ; Tue, 24 Sep 2019 20:55:03 +0000 (UTC) X-FDA: 75971018886.19.eggs56_492c827fff53f X-HE-Tag: eggs56_492c827fff53f X-Filterd-Recvd-Size: 2664 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Sep 2019 20:55:02 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id 1EDD83E9FF; Tue, 24 Sep 2019 20:55:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 1BF793E9E5; Tue, 24 Sep 2019 20:55:02 +0000 (UTC) Date: Tue, 24 Sep 2019 20:55:02 +0000 (UTC) From: cl@linux.com X-X-Sender: cl@www.lameter.com To: Matthew Wilcox cc: "Darrick J. Wong" , dsterba@suse.cz, Vlastimil Babka , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pekka Enberg , David Rientjes , Ming Lei , Dave Chinner , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, James Bottomley , linux-btrfs@vger.kernel.org, Roman Gushchin , Johannes Weiner Subject: Re: [PATCH v2 2/2] mm, sl[aou]b: guarantee natural alignment for kmalloc(power-of-two) In-Reply-To: <20190924205133.GK1855@bombadil.infradead.org> Message-ID: References: <20190826111627.7505-1-vbabka@suse.cz> <20190826111627.7505-3-vbabka@suse.cz> <20190923171710.GN2751@twin.jikos.cz> <20190923175146.GT2229799@magnolia> <20190924205133.GK1855@bombadil.infradead.org> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: n Tue, 24 Sep 2019, Matthew Wilcox wrote: > > There was a public discussion about this issue and from what I can tell > > the outcome was that the allocator already provides what you want. Which > > was a mechanism to misalign objects and detect these issues. This > > mechanism has been in use for over a decade. > > You missed the important part, which was *ENABLED BY DEFAULT*. People > who are enabling a debugging option to debug their issues, should not > have to first debug all the other issues that enabling that debugging > option uncovers! Why would you have to debug all other issues? You could put your patch on top of the latest stable or distro kernel for testing. And I thought the rc phase was there for everyone to work on the bugs of each other?