From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD526C4360D for ; Sat, 21 Sep 2019 17:00:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B1B620820 for ; Sat, 21 Sep 2019 17:00:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B1B620820 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C9DBC6B0003; Sat, 21 Sep 2019 13:00:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4EF06B0006; Sat, 21 Sep 2019 13:00:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3C3E6B0007; Sat, 21 Sep 2019 13:00:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 8CD6B6B0003 for ; Sat, 21 Sep 2019 13:00:52 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 1F65452B3 for ; Sat, 21 Sep 2019 17:00:52 +0000 (UTC) X-FDA: 75959542344.19.drink55_24a677ed48162 X-HE-Tag: drink55_24a677ed48162 X-Filterd-Recvd-Size: 1946 Received: from gentwo.org (gentwo.org [3.19.106.255]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Sat, 21 Sep 2019 17:00:51 +0000 (UTC) Received: by gentwo.org (Postfix, from userid 1002) id 546873EEB4; Sat, 21 Sep 2019 17:00:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 5325B3E86F; Sat, 21 Sep 2019 17:00:51 +0000 (UTC) Date: Sat, 21 Sep 2019 17:00:51 +0000 (UTC) From: cl@linux.com X-X-Sender: cl@ip-172-31-20-140.us-east-2.compute.internal To: David Rientjes cc: Miles Chen , Pekka Enberg , Joonsoo Kim , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-mediatek@lists.infradead.org, wsd_upstream@mediatek.com Subject: Re: [PATCH] mm: slub: print_hex_dump() with DUMP_PREFIX_OFFSET In-Reply-To: Message-ID: References: <20190920104849.32504-1-miles.chen@mediatek.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 21 Sep 2019, David Rientjes wrote: > I agree it looks nicer for poisoning, I'm not sure that every caller of > print_section() is the same, however. For example trace() seems better > off as DUMP_PREFIX_ADDRESS since it already specifies the address of the > object being allocated or freed and offset here wouldn't really be useful, > no? The address is printed earlier before the object dump. Maybe that is sufficient and we could even reduce the number of digits further to have the display more compact? In this case two hex digits would do the trick.