From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.1 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D3EDC4CEC7 for ; Sun, 15 Sep 2019 21:38:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F3EB2214AF for ; Sun, 15 Sep 2019 21:38:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nkfGFVK2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3EB2214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A44156B0010; Sun, 15 Sep 2019 17:38:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE256B0266; Sun, 15 Sep 2019 17:38:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 896666B0269; Sun, 15 Sep 2019 17:38:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 65B776B0010 for ; Sun, 15 Sep 2019 17:38:43 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 0DE90181AC9AE for ; Sun, 15 Sep 2019 21:38:43 +0000 (UTC) X-FDA: 75938469726.22.value20_4c0ad1c600f1d X-HE-Tag: value20_4c0ad1c600f1d X-Filterd-Recvd-Size: 7862 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by imf50.hostedemail.com (Postfix) with ESMTP for ; Sun, 15 Sep 2019 21:38:42 +0000 (UTC) Received: by mail-pl1-f196.google.com with SMTP id d3so15910062plr.1 for ; Sun, 15 Sep 2019 14:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=MAT1lEQ0+T2ks1DxMnED/jZFBuvcxA8EK3pKbjo1kZQ=; b=nkfGFVK2Mxxbgt9AbNyjlXvJKinTPYewFk9n+uFMt9NHlF1grSbntf37vJBoa+WF8k UEyChop3gE/0R6v0PjW0qnRTJiKizHMZcTqMbNwp1mWZuF9SdhX4v3+w9f/lujl4cg9G XzDKC4eLW5f0lkZcXAAqKTOuifsNzN+jjIymkA/9BQ/z+aDtX4ohdq+TWgIvm+tvHXx4 ihsXUsET5qNs/1YXCIk1iqkaM/cAT/gyj1LJtS7JKJTCOyAtLTdvM4NtcfvKwoiDEdYA EHCBqjp+LVBtGz/IthDEDb6NKAy7F9AHvcnajbnJZn2r4xccnoR+0f9CDWAOJULGlYQ3 gVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=MAT1lEQ0+T2ks1DxMnED/jZFBuvcxA8EK3pKbjo1kZQ=; b=uFM/5L9bfdm17fQ7f9/vXbdgGDvVVQ4MZCN8SgTiIIQmDuDPJKwjtxiBSKMFE1FXoo iBKhyOQYtpjSMq1KNvxG6zQD5qivj5SW4qtToH/QluqdqQW1czVVRJc3695wxZS8m59i u0R8orCbUxpJTkNDx9kPC9CXN9M71jSyGCSZF8lZD5JrmeyO9aS4IQm+K5Ysj5QCZ6pG ytMP8Z87nWpqgpfNm8n6towj9OLOuHh33ZU/4joCcRSHxl4+BvS1snL4rPR2ILiQooil ls2qG4nucf+BVkEV+nWYpyUeSEeZId8h6jljmkr0nYuLuA/mbEq9bNLXwxWseTTqo4sX 8LCg== X-Gm-Message-State: APjAAAW/qzDaPLg0Ph5JlMkCRTrMuxFXeTtsGqD9gxo6A+0nvAHs3zeH CoLtIVO9sxvrOtjW7RoxzkgL9A== X-Google-Smtp-Source: APXvYqyw2Tsm/cJheWXSlj1/7n28xc0eKU2c+7R/u6BCb525eniWT7rbuVlsd0rvFatIpx71+uqV0w== X-Received: by 2002:a17:902:6b04:: with SMTP id o4mr16436578plk.278.1568583521219; Sun, 15 Sep 2019 14:38:41 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id a1sm30031028pgh.61.2019.09.15.14.38.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Sep 2019 14:38:40 -0700 (PDT) Date: Sun, 15 Sep 2019 14:38:40 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Pengfei Li cc: akpm@linux-foundation.org, vbabka@suse.cz, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, guro@fb.com Subject: Re: [RESEND v4 7/7] mm, slab_common: Modify kmalloc_caches[type][idx] to kmalloc_caches[idx][type] In-Reply-To: <20190915170809.10702-8-lpf.vector@gmail.com> Message-ID: References: <20190915170809.10702-1-lpf.vector@gmail.com> <20190915170809.10702-8-lpf.vector@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000488, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 16 Sep 2019, Pengfei Li wrote: > KMALLOC_NORMAL is the most frequently accessed, and kmalloc_caches[] > is initialized by different types of the same size. > > So modifying kmalloc_caches[type][idx] to kmalloc_caches[idx][type] > will benefit performance. > > $ ./scripts/bloat-o-meter vmlinux.patch_1-6 vmlinux.patch_1-7 > add/remove: 0/0 grow/shrink: 2/57 up/down: 8/-457 (-449) > Function old new delta > tg3_self_test 4255 4259 +4 > nf_queue 666 670 +4 > kmalloc_slab 97 93 -4 > i915_sw_fence_await_dma_fence 441 437 -4 > __igmp_group_dropped 619 615 -4 > gss_import_sec_context 176 170 -6 > xhci_alloc_command 212 205 -7 > create_kmalloc_caches 155 148 -7 > xprt_switch_alloc 136 128 -8 > xhci_segment_alloc 297 289 -8 > xhci_ring_alloc 369 361 -8 > xhci_mem_init 3664 3656 -8 > xhci_alloc_virt_device 496 488 -8 > xhci_alloc_tt_info 346 338 -8 > xhci_alloc_stream_info 718 710 -8 > xhci_alloc_container_ctx 215 207 -8 > xfrm_policy_alloc 271 263 -8 > tcp_sendmsg_locked 3120 3112 -8 > tcp_md5_do_add 774 766 -8 > tcp_fastopen_defer_connect 270 262 -8 > sr_read_tochdr.isra 251 243 -8 > sr_read_tocentry.isra 328 320 -8 > sr_is_xa 376 368 -8 > sr_get_mcn 260 252 -8 > selinux_sk_alloc_security 113 105 -8 > sdev_evt_send_simple 118 110 -8 > sdev_evt_alloc 79 71 -8 > scsi_probe_and_add_lun 2938 2930 -8 > sbitmap_queue_init_node 418 410 -8 > ring_buffer_read_prepare 94 86 -8 > request_firmware_nowait 396 388 -8 > regulatory_hint_found_beacon 394 386 -8 > ohci_urb_enqueue 3176 3168 -8 > nla_strdup 142 134 -8 > nfs_alloc_seqid 87 79 -8 > nfs4_get_state_owner 1040 1032 -8 > nfs4_do_close 578 570 -8 > nf_ct_tmpl_alloc 85 77 -8 > mempool_create_node 164 156 -8 > ip_setup_cork 362 354 -8 > ip6_setup_cork 1021 1013 -8 > gss_create_cred 140 132 -8 > drm_flip_work_allocate_task 70 62 -8 > dma_pool_alloc 410 402 -8 > devres_open_group 214 206 -8 > cfg80211_stop_iface 260 252 -8 > cfg80211_sinfo_alloc_tid_stats 77 69 -8 > cfg80211_port_authorized 212 204 -8 > cfg80211_parse_mbssid_data 2397 2389 -8 > cfg80211_ibss_joined 335 327 -8 > call_usermodehelper_setup 149 141 -8 > bpf_prog_alloc_no_stats 182 174 -8 > blk_alloc_flush_queue 191 183 -8 > bdi_alloc_node 195 187 -8 > audit_log_d_path 196 188 -8 > _netlbl_catmap_getnode 247 239 -8 > ____ip_mc_inc_group 475 467 -8 > __i915_sw_fence_await_sw_fence 417 405 -12 > ida_alloc_range 955 934 -21 > Total: Before=14874316, After=14873867, chg -0.00% > > Signed-off-by: Pengfei Li This also seems more intuitive. Acked-by: David Rientjes