From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DF4C43613 for ; Fri, 21 Jun 2019 20:54:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 407ED206B7 for ; Fri, 21 Jun 2019 20:54:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="BI31JsaF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 407ED206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C7E976B0003; Fri, 21 Jun 2019 16:54:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C56198E0002; Fri, 21 Jun 2019 16:54:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B453D8E0001; Fri, 21 Jun 2019 16:54:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by kanga.kvack.org (Postfix) with ESMTP id 7D8996B0003 for ; Fri, 21 Jun 2019 16:54:06 -0400 (EDT) Received: by mail-pf1-f198.google.com with SMTP id c17so5054288pfb.21 for ; Fri, 21 Jun 2019 13:54:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :in-reply-to:message-id:references:user-agent:mime-version; bh=+OoZ/yZue0TmErM/yxfWH2TRWbijAlEGvAbUYgMmZLE=; b=j7mPGNaUaGcSHpDXJJ+JPNBVd0p8gVE+v+bloAGe57nIIovdpRGuFW4Ah3pUA4Iir+ eGoQY6brkk/HcgPlNqIkupy5FufTHPSHndHCF7CNhwIEPGiByyzT+0tFag8h46RkUbpE Yb+bXlPbQnyv8LxzDYBU+V4U51GgrZFUIldyxjVvxI5ijfLbb+LT1q8W/TpNwTA3vLLV cDq48vQY0fBG4OPrluHLnA6jNy1XONzyI6BKeYVm3b9oc5EyfTFXgM/OesIY/N+e09pe 1yjhgMHGBIA4dcdMMxCiNvCcVhvrmx3tkIiZH8+qy5H+27sZnWBnAfDTldbYSxSiqhvI lGUg== X-Gm-Message-State: APjAAAVbblGyHx/UACKRRMTDacU/cG1WrmioV3Q2VJTI8NXehg8hOI2B gRKtq8jVlxbL9i3X9bqsuxfKf6+ICTPRjX1qzfScq/W6SeIN+0QlTeH9gMOJ5MqtU3xGPeQXBKB IA2XIPelfjiwuiyzscoJ+OP8D96LCARY33B0PYd/WwdOqDaY83Kw1vBr+pdtP8MovsQ== X-Received: by 2002:a63:9143:: with SMTP id l64mr9707601pge.65.1561150445994; Fri, 21 Jun 2019 13:54:05 -0700 (PDT) X-Received: by 2002:a63:9143:: with SMTP id l64mr9707543pge.65.1561150445008; Fri, 21 Jun 2019 13:54:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561150445; cv=none; d=google.com; s=arc-20160816; b=MtN1JXata0yYZ6udDIRgOkY+i/4RbfzfLRMg6y6lRH15oQGFVm3mptllvS77lYEhrn BxZTuQ6en2i4YYGTTv+Si/AgRrCLylF8OBiWt7oWC6qzZpf1Zkx9gZwMDf2/mU52tSfW WnvvE8YAAlSay2V3WB9ntC7B7YiFrHH9mYIse8YpJcyLFw0D1OS4Jx1Y4tNalCzLCtyw ZgaAZxzc4qbbdps9OgxzmiGpM18Rmbh3r5X0om2g0qQ5sWxKzZjFbYZFgddOR7x+qIPi 1Us6KicLGg+tBD+vG2MFqBMe7mZMwGdTMmCw0xfnf4gqu4tK23Rc2EtIMtrVMX3GFUe5 NRQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date:dkim-signature; bh=+OoZ/yZue0TmErM/yxfWH2TRWbijAlEGvAbUYgMmZLE=; b=lPJmox+gvbZYGwOQnUCedZR2JBYChXoPaWKxqmXF0JRY0rhPn8jTaVG3broHoYDC31 DBuKXgcVDe8M2KkUrmkWnS3WOhkDciC98GT7Q5lbXREkjeoioTbMToZOLX4xHylCiqw5 hRwMeb4XKLkelp+Eo+EO8sQSq68Jq2Hj0LJbhKfNm1kPM6IshJKJCI06vmBY6tuG7j4I 4/CTdQeYaxs3/6u3g6RQbUg/8gV5FJ7c7oQ49ofOOCDstzreKutxF9Pq9Ajex8IcROOx zcFenG8c5G7wUlwhLUeQiGofv+zbIS6+Lp1hy/MZeeuVgVsVcfnzQSsnnP0mGttqm6r6 8Khw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=BI31JsaF; spf=pass (google.com: domain of rientjes@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id q62sor5416151pjb.10.2019.06.21.13.54.04 for (Google Transport Security); Fri, 21 Jun 2019 13:54:04 -0700 (PDT) Received-SPF: pass (google.com: domain of rientjes@google.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=BI31JsaF; spf=pass (google.com: domain of rientjes@google.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=+OoZ/yZue0TmErM/yxfWH2TRWbijAlEGvAbUYgMmZLE=; b=BI31JsaFNk04cIzIG7G2Iuux9FOLoT2qKKw2WU8H0Ik+TyznIET6DVQHdEqq01bujf BlgOPh+di0+im7bkY+6BcKA1qJMkEpaICbiA140fphdP7ioHaU0V2Y1KbUmNKv6HtJvJ q11Hfb6hqGs9OsktfXSF36sxur281VGrljRHnobCHehWkWrtrTukpspeoSFtfdIX9E13 tePF4BRUqQdPGASkbxcqrU+oawmA6zCui7S7xqdYjH7dO3P22FqIvlwxJJgoSdJW3hOS 0tgF/+VJPsGAdZEp5efIYaFQ9Z5gz2yf3wMk1WheVkLluNuSJ/bnyX4fKNAznH01kikq SFJQ== X-Google-Smtp-Source: APXvYqxRG2NXRMDxRNPRaE5GYHtKwNJjBkVVhjltsCNm5jWbnwo8H3Q77bmmkK+vq3AmOgyLReGFIA== X-Received: by 2002:a17:90a:30e4:: with SMTP id h91mr8723116pjb.37.1561150444324; Fri, 21 Jun 2019 13:54:04 -0700 (PDT) Received: from [2620:15c:17:3:3a5:23a7:5e32:4598] ([2620:15c:17:3:3a5:23a7:5e32:4598]) by smtp.gmail.com with ESMTPSA id g8sm3704462pfi.8.2019.06.21.13.54.03 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 21 Jun 2019 13:54:03 -0700 (PDT) Date: Fri, 21 Jun 2019 13:54:03 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: Roman Gushchin cc: Andrew Morton , Vladimir Davydov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@fb.com, Johannes Weiner , Shakeel Butt , Waiman Long , Andrei Vagin , Christoph Lameter , Michal Hocko , Joonsoo Kim , Pekka Enberg Subject: Re: [PATCH v2] mm: memcg/slab: properly handle kmem_caches reparented to root_mem_cgroup In-Reply-To: <20190620213427.1691847-1-guro@fb.com> Message-ID: References: <20190620213427.1691847-1-guro@fb.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 20 Jun 2019, Roman Gushchin wrote: > As a result of reparenting a kmem_cache might belong to the root > memory cgroup. It happens when a top-level memory cgroup is removed, > and all associated kmem_caches are reparented to the root memory > cgroup. > > The root memory cgroup is special, and requires a special handling. > Let's make sure that we don't try to charge or uncharge it, > and we handle system-wide vmstats exactly as for root kmem_caches. > > Note, that we still need to alter the kmem_cache reference counter, > so that the kmem_cache can be released properly. > > The issue was discovered by running CRIU tests; the following warning > did appear: > > [ 381.345960] WARNING: CPU: 0 PID: 11655 at mm/page_counter.c:62 > page_counter_cancel+0x26/0x30 > [ 381.345992] Modules linked in: > [ 381.345998] CPU: 0 PID: 11655 Comm: kworker/0:8 Not tainted > 5.2.0-rc5-next-20190618+ #1 > [ 381.346001] Hardware name: Google Google Compute Engine/Google > Compute Engine, BIOS Google 01/01/2011 > [ 381.346010] Workqueue: memcg_kmem_cache kmemcg_workfn > [ 381.346013] RIP: 0010:page_counter_cancel+0x26/0x30 > [ 381.346017] Code: 1f 44 00 00 0f 1f 44 00 00 48 89 f0 53 48 f7 d8 > f0 48 0f c1 07 48 29 f0 48 89 c3 48 89 c6 e8 61 ff ff ff 48 85 db 78 > 02 5b c3 <0f> 0b 5b c3 66 0f 1f 44 00 00 0f 1f 44 00 00 48 85 ff 74 41 > 41 55 > [ 381.346019] RSP: 0018:ffffb3b34319f990 EFLAGS: 00010086 > [ 381.346022] RAX: fffffffffffffffc RBX: fffffffffffffffc RCX: 0000000000000004 > [ 381.346024] RDX: 0000000000000000 RSI: fffffffffffffffc RDI: ffff9c2cd7165270 > [ 381.346026] RBP: 0000000000000004 R08: 0000000000000000 R09: 0000000000000001 > [ 381.346028] R10: 00000000000000c8 R11: ffff9c2cd684e660 R12: 00000000fffffffc > [ 381.346030] R13: 0000000000000002 R14: 0000000000000006 R15: ffff9c2c8ce1f200 > [ 381.346033] FS: 0000000000000000(0000) GS:ffff9c2cd8200000(0000) > knlGS:0000000000000000 > [ 381.346039] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 381.346041] CR2: 00000000007be000 CR3: 00000001cdbfc005 CR4: 00000000001606f0 > [ 381.346043] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 381.346045] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 381.346047] Call Trace: > [ 381.346054] page_counter_uncharge+0x1d/0x30 > [ 381.346065] __memcg_kmem_uncharge_memcg+0x39/0x60 > [ 381.346071] __free_slab+0x34c/0x460 > [ 381.346079] deactivate_slab.isra.80+0x57d/0x6d0 > [ 381.346088] ? add_lock_to_list.isra.36+0x9c/0xf0 > [ 381.346095] ? __lock_acquire+0x252/0x1410 > [ 381.346106] ? cpumask_next_and+0x19/0x20 > [ 381.346110] ? slub_cpu_dead+0xd0/0xd0 > [ 381.346113] flush_cpu_slab+0x36/0x50 > [ 381.346117] ? slub_cpu_dead+0xd0/0xd0 > [ 381.346125] on_each_cpu_mask+0x51/0x70 > [ 381.346131] ? ksm_migrate_page+0x60/0x60 > [ 381.346134] on_each_cpu_cond_mask+0xab/0x100 > [ 381.346143] __kmem_cache_shrink+0x56/0x320 > [ 381.346150] ? ret_from_fork+0x3a/0x50 > [ 381.346157] ? unwind_next_frame+0x73/0x480 > [ 381.346176] ? __lock_acquire+0x252/0x1410 > [ 381.346188] ? kmemcg_workfn+0x21/0x50 > [ 381.346196] ? __mutex_lock+0x99/0x920 > [ 381.346199] ? kmemcg_workfn+0x21/0x50 > [ 381.346205] ? kmemcg_workfn+0x21/0x50 > [ 381.346216] __kmemcg_cache_deactivate_after_rcu+0xe/0x40 > [ 381.346220] kmemcg_cache_deactivate_after_rcu+0xe/0x20 > [ 381.346223] kmemcg_workfn+0x31/0x50 > [ 381.346230] process_one_work+0x23c/0x5e0 > [ 381.346241] worker_thread+0x3c/0x390 > [ 381.346248] ? process_one_work+0x5e0/0x5e0 > [ 381.346252] kthread+0x11d/0x140 > [ 381.346255] ? kthread_create_on_node+0x60/0x60 > [ 381.346261] ret_from_fork+0x3a/0x50 > [ 381.346275] irq event stamp: 10302 > [ 381.346278] hardirqs last enabled at (10301): [] > _raw_spin_unlock_irq+0x29/0x40 > [ 381.346282] hardirqs last disabled at (10302): [] > on_each_cpu_mask+0x49/0x70 > [ 381.346287] softirqs last enabled at (10262): [] > cgroup_idr_replace+0x3a/0x50 > [ 381.346290] softirqs last disabled at (10260): [] > cgroup_idr_replace+0x1d/0x50 > [ 381.346293] ---[ end trace b324ba73eb3659f0 ]--- > > v2: fixed return value from memcg_charge_slab(), spotted by Shakeel > > Reported-by: Andrei Vagin > Signed-off-by: Roman Gushchin > Cc: Christoph Lameter > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Shakeel Butt > Cc: Vladimir Davydov > Cc: Waiman Long > Cc: David Rientjes > Cc: Joonsoo Kim > Cc: Pekka Enberg Acked-by: David Rientjes