linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, cl@linux.com, penberg@kernel.org,
	 iamjoonsoo.kim@lge.com, catalin.marinas@arm.com,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] slab: skip kmemleak_object in leaks_show()
Date: Mon, 20 May 2019 10:18:05 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.1905201017420.96074@chino.kir.corp.google.com> (raw)
In-Reply-To: <20190514144741.39460-1-cai@lca.pw>

On Tue, 14 May 2019, Qian Cai wrote:

> Running tests on a debug kernel will usually generate a large number of
> kmemleak objects.
> 
>   # grep kmemleak /proc/slabinfo
>   kmemleak_object   2243606 3436210 ...
> 
> As the result, reading /proc/slab_allocators could easily loop forever
> while processing the kmemleak_object cache and any additional freeing or
> allocating objects will trigger a reprocessing. To make a situation
> worse, soft-lockups could easily happen in this sitatuion which will
> call printk() to allocate more kmemleak objects to guarantee a livelock.
> 
> Since kmemleak_object has a single call site (create_object()), there
> isn't much new information compared with slabinfo. Just skip it.
> 
> Signed-off-by: Qian Cai <cai@lca.pw>

I assume this is now obsolete since commit 7878c231dae0 ("slab: remove 
/proc/slab_allocators").


      reply	other threads:[~2019-05-20 17:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14 14:47 Qian Cai
2019-05-20 17:18 ` David Rientjes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.21.1905201017420.96074@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=cai@lca.pw \
    --cc=catalin.marinas@arm.com \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox