From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 949F3C10F0E for ; Thu, 18 Apr 2019 11:54:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C5052183F for ; Thu, 18 Apr 2019 11:54:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C5052183F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DD6C46B0008; Thu, 18 Apr 2019 07:54:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAE126B000A; Thu, 18 Apr 2019 07:54:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6DA6B000C; Thu, 18 Apr 2019 07:54:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by kanga.kvack.org (Postfix) with ESMTP id 81F866B0008 for ; Thu, 18 Apr 2019 07:54:46 -0400 (EDT) Received: by mail-wr1-f69.google.com with SMTP id e6so1888550wrs.1 for ; Thu, 18 Apr 2019 04:54:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:date:from:to :cc:subject:in-reply-to:message-id:references:user-agent :mime-version; bh=LOgANvyzyMKmFS7vK2SQ+FqWR8dwhKrP+WoREASkiiI=; b=I85V/+s6b+xhQQ/4rT/8CHNrg8cYyoRxYil4UnWsNesQu5QzGFZOrPh2QmpTT2kKJs znwpw8t0zEOdqyx+/qsmQTnH/SrMxA+m0hX1mz3RumfGoIyJ68gkivVC+ak5MRXlV3fg 6TlmbCuO4KBHKSA/MH4ZX537eHWTQI7crKmi6Y5H+dNsvJIjG+X13e8O9d50D/2mq4wW Ike8yr3u/DNqV0Sy9blfA9ZynazdBCT6Wbno8qX5wBm5Ur3eA9D6XipXBRcP6q38k24N AlEwpElJ5D8oOddG2AAE70Tor0B9XskE/koiWhvz9VQpRe4oEBFxvAjkt3SkKoApgzPl js0A== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de X-Gm-Message-State: APjAAAU0CdrAhysVfnLX6zd0UfAl442r9jGf9QOb6Iz3AkcGBjptcfCi 9Pa1JnB66Mprt/yzvACsT9v/rhqXrdSdwF8tcgnEShtJ68eoSO2SBq1MgFRT+vvCHNXYYnS1Gua UtizAu3PEqy2Xits4Hh8r90j4Iw2nKHEhPR/gDXjQxo1ictMpykWw602dFLvZXCRc0Q== X-Received: by 2002:adf:df92:: with SMTP id z18mr55007533wrl.239.1555588486103; Thu, 18 Apr 2019 04:54:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqyqCF6itwvSoFzR/dmT+qUHN9HsgTgkth3EGv+L57IW8/dyL/t4xY+e85w+Ga+FI1v3MXEY X-Received: by 2002:adf:df92:: with SMTP id z18mr55007476wrl.239.1555588485221; Thu, 18 Apr 2019 04:54:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555588485; cv=none; d=google.com; s=arc-20160816; b=h6kSXsAFsO0gJ3P21rLgKAIefFd1k9q+LCsibDmSeoObKSFfOlB1tAJ3dYTaWiWnql vzezBujnn5RnuFuBPMPAljjknIN4Xl8e0TyN8AwcD5P9390bLkILtGu5WgU73elWtUNi IMPO39wGy3mkV2AtF03OxgQAF0YdyzD42Ky+/fBZmanZHf4NX5eXLeHTKs/Jahq8Jqm9 ARhgYw+rNmIdX/OpSfVraXGFM2FCnQZxlP10rihQITLynaB5hxkhSWP3Cjy2h3WKkUUn Yof2qX3YUeq+jqlBJWk6YkIXRS1awJFuepK2u9QVMMjRU1uIU+0EFDuG3+IcgUcBDR6L GI2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:message-id:in-reply-to:subject :cc:to:from:date; bh=LOgANvyzyMKmFS7vK2SQ+FqWR8dwhKrP+WoREASkiiI=; b=EtHuwfHF9MInV6mIGHFcKRoGDbNLl+1baaLl+cEp+wPuwFzav5J/iFJD60437YJYgN dBjaTsIXH4zLeQQ0I3o1RdCeVmH2PvzOi6HpainWzqx32sOF8QjD+YGC0lyvrmDXofIC oC/z17LjL/ybOaafxyEAAhx/GaZgfBGeEUBg9gdyXThidYU04qXdx+hKjcxjSochTzUt dgZoFNc70tfuWGvh+QZuVapMlj0dn/qNZC3dLVsO48ElGXxeOPHF1P1RAqNFuDMGRJ6J rkPw72BwHbHVO7slZaCCjT0Yzz/jiDJDhlk3V552DbaAIMPT/dQhPArNkh3gc62KxEIJ yLlg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id h15si1459017wrx.148.2019.04.18.04.54.45 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 18 Apr 2019 04:54:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) client-ip=2a01:7a0:2:106d:700::1; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of tglx@linutronix.de designates 2a01:7a0:2:106d:700::1 as permitted sender) smtp.mailfrom=tglx@linutronix.de Received: from pd9ef12d2.dip0.t-ipconnect.de ([217.239.18.210] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hH5ck-00063t-VR; Thu, 18 Apr 2019 13:54:39 +0200 Date: Thu, 18 Apr 2019 13:54:37 +0200 (CEST) From: Thomas Gleixner To: Alexander Potapenko cc: LKML , Josh Poimboeuf , x86@kernel.org, Andy Lutomirski , Steven Rostedt , dm-devel@redhat.com, Mike Snitzer , Alasdair Kergon , Alexey Dobriyan , Andrew Morton , Pekka Enberg , Linux Memory Management List , David Rientjes , Christoph Lameter , Catalin Marinas , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Mike Rapoport , Akinobu Mita , iommu@lists.linux-foundation.org, Robin Murphy , Christoph Hellwig , Marek Szyprowski , Johannes Thumshirn , David Sterba , Chris Mason , Josef Bacik , linux-btrfs@vger.kernel.org, intel-gfx@lists.freedesktop.org, Joonas Lahtinen , Maarten Lankhorst , dri-devel@lists.freedesktop.org, David Airlie , Jani Nikula , Daniel Vetter , Rodrigo Vivi , linux-arch@vger.kernel.org Subject: Re: [patch V2 14/29] dm bufio: Simplify stack trace retrieval In-Reply-To: Message-ID: References: <20190418084119.056416939@linutronix.de> <20190418084254.361284697@linutronix.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 18 Apr 2019, Alexander Potapenko wrote: > On Thu, Apr 18, 2019 at 11:06 AM Thomas Gleixner wrote: > > - save_stack_trace(&b->stack_trace); > > + b->stack_len = stack_trace_save(b->stack_entries, MAX_STACK, 2); > As noted in one of similar patches before, can we have an inline > comment to indicate what does this "2" stand for? Come on. We have gazillion of functions which take numerical constant arguments. Should we add comments to all of them? Thanks, tglx