From: Thomas Gleixner <tglx@linutronix.de>
To: Will Deacon <will.deacon@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
cpandya@codeaurora.org, toshi.kani@hpe.com, mhocko@suse.com,
akpm@linux-foundation.org, sean.j.christopherson@intel.com
Subject: Re: [PATCH v2 3/5] x86: pgtable: Drop pXd_none() checks from pXd_free_pYd_table()
Date: Tue, 2 Oct 2018 13:30:57 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1810021326300.32062@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1538478363-16255-4-git-send-email-will.deacon@arm.com>
On Tue, 2 Oct 2018, Will Deacon wrote:
Subject prefix wants to be 'x86/pgtable:' please
> Now that the core code checks this for us, we don't need to do it in the
> backend.
According to Documentation changelogs want to be written in imperative
mood.
The core code has a check for pXd_none() already. Remove it in the
architecture implementation.
Or something like that.
> Cc: Chintan Pandya <cpandya@codeaurora.org>
> Cc: Toshi Kani <toshi.kani@hpe.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Michal Hocko <mhocko@suse.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Reviewed-by: Toshi Kani <toshi.kani@hpe.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Other than the nits above:
Acked-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2018-10-02 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 11:05 [PATCH v2 0/5] Clean up huge vmap and ioremap code Will Deacon
2018-10-02 11:05 ` [PATCH v2 1/5] ioremap: Rework pXd_free_pYd_page() API Will Deacon
2018-10-02 11:06 ` [PATCH v2 2/5] arm64: mmu: Drop pXd_present() checks from pXd_free_pYd_table() Will Deacon
2018-10-02 11:06 ` [PATCH v2 3/5] x86: pgtable: Drop pXd_none() " Will Deacon
2018-10-02 11:30 ` Thomas Gleixner [this message]
2018-10-02 11:06 ` [PATCH v2 4/5] lib/ioremap: Ensure phys_addr actually corresponds to a physical address Will Deacon
2018-10-02 11:06 ` [PATCH v2 5/5] lib/ioremap: Ensure break-before-make is used for huge p4d mappings Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1810021326300.32062@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=cpandya@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=sean.j.christopherson@intel.com \
--cc=toshi.kani@hpe.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox