From: David Rientjes <rientjes@google.com>
To: ufo19890607@gmail.com
Cc: akpm@linux-foundation.org, mhocko@suse.com,
kirill.shutemov@linux.intel.com, aarcange@redhat.com,
penguin-kernel@i-love.sakura.ne.jp, guro@fb.com,
yang.s@alibaba-inc.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, yuzhoujian@didichuxing.com
Subject: Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information
Date: Fri, 13 Jul 2018 15:22:17 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1807131521030.202408@chino.kir.corp.google.com> (raw)
In-Reply-To: <1531482952-4595-1-git-send-email-ufo19890607@gmail.com>
On Fri, 13 Jul 2018, ufo19890607@gmail.com wrote:
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> index 531b2c86d4db..7fbd389ea779 100644
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -434,10 +434,11 @@ static void dump_header(struct oom_control *oc, struct task_struct *p)
> oom_constraint_text[oc->constraint],
> nodemask_pr_args(oc->nodemask));
> cpuset_print_current_mems_allowed();
> + mem_cgroup_print_oom_context(oc->memcg, p);
> pr_cont(",task=%s,pid=%5d,uid=%5d\n", p->comm, p->pid,
> from_kuid(&init_user_ns, task_uid(p)));
> if (is_memcg_oom(oc))
> - mem_cgroup_print_oom_info(oc->memcg, p);
> + mem_cgroup_print_oom_meminfo(oc->memcg);
> else {
> show_mem(SHOW_MEM_FILTER_NODES, oc->nodemask);
> if (is_dump_unreclaim_slabs())
Ugh, could we please not pad the pid and uid with spaces? I don't think
it achieves anything and just makes regex less robust.
Otherwise, looks good!
next prev parent reply other threads:[~2018-07-13 22:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 11:55 ufo19890607
2018-07-13 13:13 ` Michal Hocko
2018-07-13 22:22 ` David Rientjes [this message]
2018-07-15 1:08 ` 禹舟键
2018-07-17 3:51 ` David Rientjes
-- strict thread matches above, loose matches on Subject: below --
2018-07-10 10:19 [PATCH v13 1/2] Reorganize the oom report in dump_header ufo19890607
2018-07-10 10:19 ` [PATCH v13 2/2] Add oom victim's memcg to the oom context information ufo19890607
2018-07-10 12:08 ` Michal Hocko
2018-07-11 3:39 ` 禹舟键
2018-07-11 7:53 ` Michal Hocko
2018-07-11 10:31 ` 禹舟键
2018-07-11 11:10 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1807131521030.202408@chino.kir.corp.google.com \
--to=rientjes@google.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=ufo19890607@gmail.com \
--cc=yang.s@alibaba-inc.com \
--cc=yuzhoujian@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox