From: Christopher Lameter <cl@linux.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] slub: Remove use of page->counter
Date: Mon, 16 Apr 2018 10:08:54 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1804161007450.8424@nuc-kabylake> (raw)
In-Reply-To: <20180416135321.GD26022@bombadil.infradead.org>
On Mon, 16 Apr 2018, Matthew Wilcox wrote:
> struct { /* Slub */
> struct kmem_cache *slub_cache;
> /* Dword boundary */
> void *slub_freelist;
> unsigned short inuse;
> unsigned short objects:15;
> unsigned short frozen:1;
> struct page *next;
> #ifdef CONFIG_64BIT
> int pobjects;
> int pages;
> #endif
> short int pages;
> short int pobjects;
> #endif
That looks better.
> I'd want to change slob to use slob_list instead of ->lru. Or maybe even do
> something radical like _naming_ the struct in the union so we don't have to
> manually namespace the names of the elements.
Hmmm... How would that look?
prev parent reply other threads:[~2018-04-16 15:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 19:54 Matthew Wilcox
2018-04-10 20:47 ` Christopher Lameter
2018-04-10 20:57 ` Matthew Wilcox
2018-04-10 22:03 ` Christopher Lameter
2018-04-11 18:26 ` Matthew Wilcox
2018-04-16 13:53 ` Matthew Wilcox
2018-04-16 15:08 ` Christopher Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1804161007450.8424@nuc-kabylake \
--to=cl@linux.com \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox