From: Christopher Lameter <cl@linux.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, Matthew Wilcox <mawilcox@microsoft.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@redhat.com>,
Mel Gorman <mgorman@techsingularity.net>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] slab: __GFP_ZERO is incompatible with a constructor
Date: Tue, 10 Apr 2018 09:26:19 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1804100925520.27641@nuc-kabylake> (raw)
In-Reply-To: <alpine.DEB.2.20.1804100920110.27333@nuc-kabylake>
On Tue, 10 Apr 2018, Christopher Lameter wrote:
> On Tue, 10 Apr 2018, Matthew Wilcox wrote:
>
> > __GFP_ZERO requests that the object be initialised to all-zeroes,
> > while the purpose of a constructor is to initialise an object to a
> > particular pattern. We cannot do both. Add a warning to catch any
> > users who mistakenly pass a __GFP_ZERO flag when allocating a slab with
> > a constructor.
>
> Can we move this check out of the critical paths and check for
> a ctor and GFP_ZERO when calling the page allocator? F.e. in
> allocate_slab()?
The ctor's are run at that point from setup_object() so it makes sense.
next prev parent reply other threads:[~2018-04-10 14:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 12:53 Matthew Wilcox
2018-04-10 12:53 ` [PATCH 2/2] page cache: Mask off unwanted GFP flags Matthew Wilcox
2018-04-10 13:08 ` Johannes Weiner
2018-04-10 13:09 ` Michal Hocko
2018-04-10 13:45 ` Minchan Kim
2018-04-10 14:02 ` Matthew Wilcox
2018-04-10 15:18 ` Jaegeuk Kim
2018-04-10 13:46 ` Jan Kara
2018-04-10 13:00 ` [PATCH 1/2] slab: __GFP_ZERO is incompatible with a constructor Johannes Weiner
2018-04-10 13:07 ` Michal Hocko
2018-04-10 13:40 ` Vlastimil Babka
2018-04-10 13:53 ` Eric Dumazet
2018-04-10 16:50 ` Matthew Wilcox
2018-04-10 17:30 ` Christopher Lameter
2018-04-10 17:38 ` Matthew Wilcox
2018-04-10 17:45 ` Christopher Lameter
2018-04-10 17:50 ` Matthew Wilcox
2018-04-10 20:21 ` Christopher Lameter
2018-04-10 14:21 ` Christopher Lameter
2018-04-10 14:26 ` Christopher Lameter [this message]
2018-04-10 15:54 ` Matthew Wilcox
2018-04-10 17:04 ` Christopher Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1804100925520.27641@nuc-kabylake \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jack@suse.cz \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=mgorman@techsingularity.net \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox