From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <owner-linux-mm@kvack.org>
Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199])
	by kanga.kvack.org (Postfix) with ESMTP id F3BBB6B0033
	for <linux-mm@kvack.org>; Tue, 14 Nov 2017 10:05:28 -0500 (EST)
Received: by mail-wr0-f199.google.com with SMTP id f9so11290871wra.2
        for <linux-mm@kvack.org>; Tue, 14 Nov 2017 07:05:28 -0800 (PST)
Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1])
        by mx.google.com with ESMTPS id j97si15013335wrj.386.2017.11.14.07.05.27
        for <linux-mm@kvack.org>
        (version=TLS1_2 cipher=AES128-SHA bits=128/128);
        Tue, 14 Nov 2017 07:05:27 -0800 (PST)
Date: Tue, 14 Nov 2017 16:05:21 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] mm: drop hotplug lock from lru_add_drain_all
In-Reply-To: <20171114143200.brmgskoqxjlrhrzx@dhcp22.suse.cz>
Message-ID: <alpine.DEB.2.20.1711141605050.2044@nanos>
References: <20171114135348.28704-1-mhocko@kernel.org> <alpine.DEB.2.20.1711141512180.2044@nanos> <20171114142347.syzyd6tlnpe2afur@dhcp22.suse.cz> <20171114143200.brmgskoqxjlrhrzx@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: owner-linux-mm@kvack.org
List-ID: <linux-mm.kvack.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>, Tejun Heo <tj@kernel.org>, Peter Zijlstra <peterz@infradead.org>, Johannes Weiner <hannes@cmpxchg.org>, Mel Gorman <mgorman@suse.de>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>

On Tue, 14 Nov 2017, Michal Hocko wrote:

> On Tue 14-11-17 15:23:47, Michal Hocko wrote:
> [...]
> > +/*
> > + * Doesn't need any cpu hotplug locking because we do rely on per-cpu
> > + * kworkers being shut down before our page_alloc_cpu_dead callback is
> > + * executed on the offlined cpu
> > + */
> >  void lru_add_drain_all(void)
> >  {
> >  	static DEFINE_MUTEX(lock);
> 
> Ble the part of the comment didn't go through

Looks good.

Thanks,

	tglx

> diff --git a/mm/swap.c b/mm/swap.c
> index 8bfdcab9f83e..1ab8122d2d0c 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -688,6 +688,13 @@ static void lru_add_drain_per_cpu(struct work_struct *dummy)
>  
>  static DEFINE_PER_CPU(struct work_struct, lru_add_drain_work);
>  
> +/*
> + * Doesn't need any cpu hotplug locking because we do rely on per-cpu
> + * kworkers being shut down before our page_alloc_cpu_dead callback is
> + * executed on the offlined cpu.
> + * Calling this function with cpu hotplug locks held can actually lead
> + * to obscure indirect dependencies via WQ context.
> + */
>  void lru_add_drain_all(void)
>  {
>  	static DEFINE_MUTEX(lock);
> -- 
> Michal Hocko
> SUSE Labs
> 

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>