From: Christopher Lameter <cl@linux.com>
To: Alexander Popov <alex.popov@linux.com>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Andy Lutomirski <luto@kernel.org>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Tejun Heo <tj@kernel.org>, Daniel Mack <daniel@zonque.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Helge Deller <deller@gmx.de>, Rik van Riel <riel@redhat.com>,
Linux-MM <linux-mm@kvack.org>, Tycho Andersen <tycho@docker.com>,
LKML <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com" <kernel->
Subject: Re: [v3] mm: Add SLUB free list pointer obfuscation
Date: Thu, 27 Jul 2017 18:53:57 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1707271851390.17228@nuc-kabylake> (raw)
In-Reply-To: <515333f5-1815-8591-503e-c0cf6941670e@linux.com>
On Fri, 28 Jul 2017, Alexander Popov wrote:
> I don't really like ignoring double-free. I think, that:
> - it will hide dangerous bugs in the kernel,
> - it can make some kernel exploits more stable.
> I would rather add BUG_ON to set_freepointer() behind SLAB_FREELIST_HARDENED. Is
> it fine?
I think Kees already added some logging output.
> At the same time avoiding the consequences of some double-free errors is better
> than not doing that. It may be considered as kernel "self-healing", I don't
> know. I can prepare a second patch for do_slab_free(), as you described. Would
> you like it?
The SLUB allocator is already self healing if you enable the option to do
so on bootup (covers more than just the double free case). What you
propose here is no different than that and just another way of having
similar functionality. In the best case it would work the same way.
next prev parent reply other threads:[~2017-07-27 23:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 0:27 [PATCH v3] " Kees Cook
2017-07-06 13:43 ` Christoph Lameter
2017-07-06 15:48 ` Kees Cook
2017-07-06 15:55 ` Christoph Lameter
2017-07-06 16:16 ` [kernel-hardening] " Daniel Micay
2017-07-06 17:53 ` Rik van Riel
2017-07-06 18:50 ` Kees Cook
2017-07-07 13:50 ` Christoph Lameter
2017-07-07 16:51 ` Kees Cook
2017-07-07 17:06 ` Christoph Lameter
2017-07-07 18:43 ` Kees Cook
2017-07-24 21:17 ` [v3] " Alexander Popov
2017-07-25 9:42 ` Alexander Popov
2017-07-26 0:21 ` Kees Cook
2017-07-26 14:08 ` Christopher Lameter
2017-07-26 16:20 ` Kees Cook
2017-07-26 16:55 ` Christopher Lameter
2017-07-26 17:13 ` Kees Cook
2017-07-27 15:15 ` Christopher Lameter
2017-07-27 22:48 ` Alexander Popov
2017-07-27 23:53 ` Christopher Lameter [this message]
2017-07-31 20:17 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707271851390.17228@nuc-kabylake \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=bigeasy@linutronix.de \
--cc=daniel@zonque.org \
--cc=deller@gmx.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=penberg@kernel.org \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=tycho@docker.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox