From: Christopher Lameter <cl@linux.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Potapenko <glider@google.com>,
Dmitriy Vyukov <dvyukov@google.com>,
Kostya Serebryany <kcc@google.com>,
LKML <linux-kernel@vger.kernel.org>,
Linux Memory Management List <linux-mm@kvack.org>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>
Subject: Re: [PATCH] slub: make sure struct kmem_cache_node is initialized before publication
Date: Wed, 12 Jul 2017 14:57:47 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1707121456320.16986@nuc-kabylake> (raw)
In-Reply-To: <20170712122154.f6bafdc86ccfd189fefbb0a3@linux-foundation.org>
On Wed, 12 Jul 2017, Andrew Morton wrote:
> - free_kmem_cache_nodes() frees the cache node before nulling out a
> reference to it
>
> - init_kmem_cache_nodes() publishes the cache node before initializing it
>
> Neither of these matter at runtime because the cache nodes cannot be
> looked up by any other thread. But it's neater and more consistent to
> reorder these.
The compiler or processor may reorder them at will anyways. But if its
tidier....
Acked-by: Christoph Lameter <cl@linux.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2017-07-12 19:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-07 8:34 Alexander Potapenko
2017-07-07 8:43 ` Alexander Potapenko
2017-07-07 20:23 ` Andrew Morton
2017-07-07 23:18 ` Christoph Lameter
2017-07-10 9:19 ` Alexander Potapenko
2017-07-10 15:32 ` Christoph Lameter
2017-07-10 20:32 ` Andrew Morton
2017-07-12 14:11 ` Alexander Potapenko
2017-07-12 19:21 ` Andrew Morton
2017-07-12 19:57 ` Christopher Lameter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1707121456320.16986@nuc-kabylake \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox