From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f199.google.com (mail-wr0-f199.google.com [209.85.128.199]) by kanga.kvack.org (Postfix) with ESMTP id 35B196B03C1 for ; Wed, 21 Jun 2017 05:39:25 -0400 (EDT) Received: by mail-wr0-f199.google.com with SMTP id p64so3642328wrc.8 for ; Wed, 21 Jun 2017 02:39:25 -0700 (PDT) Received: from Galois.linutronix.de (Galois.linutronix.de. [2a01:7a0:2:106d:700::1]) by mx.google.com with ESMTPS id z15si17112239wrz.90.2017.06.21.02.39.23 for (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 21 Jun 2017 02:39:23 -0700 (PDT) Date: Wed, 21 Jun 2017 11:39:13 +0200 (CEST) From: Thomas Gleixner Subject: Re: [PATCH v3 10/11] x86/mm: Enable CR4.PCIDE on supported systems In-Reply-To: <57c1d18b1c11f9bc9a3bcf8bdee38033415e1a13.1498022414.git.luto@kernel.org> Message-ID: References: <57c1d18b1c11f9bc9a3bcf8bdee38033415e1a13.1498022414.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov , Linus Torvalds , Andrew Morton , Mel Gorman , "linux-mm@kvack.org" , Nadav Amit , Rik van Riel , Dave Hansen , Arjan van de Ven , Peter Zijlstra , Juergen Gross , Boris Ostrovsky On Tue, 20 Jun 2017, Andy Lutomirski wrote: > + /* Set up PCID */ > + if (cpu_has(c, X86_FEATURE_PCID)) { > + if (cpu_has(c, X86_FEATURE_PGE)) { > + cr4_set_bits(X86_CR4_PCIDE); So I assume that you made sure that the PCID bits in CR3 are zero under all circumstances as setting PCIDE would cause a #GP if not. Reviewed-by: Thomas Gleixner -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org