From: Christoph Lameter <cl@linux.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: penberg@kernel.org, rientjes@google.com,
akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] refine and rename slub sysfs
Date: Wed, 17 May 2017 09:57:28 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1705170954090.8714@east.gentwo.org> (raw)
In-Reply-To: <20170517141146.11063-1-richard.weiyang@gmail.com>
On Wed, 17 May 2017, Wei Yang wrote:
> This patch serial could be divided into two parts.
>
> First three patches refine and adds slab sysfs.
> Second three patches rename slab sysfs.
These changes will break the slabinfo tool in linux/tools/vm/slabinfo.c.
Please update it as well.
> 1. Refine slab sysfs
>
> There are four level slabs:
levels? Maybe types of slabs?
> CPU
> CPU_PARTIAL
> PARTIAL
> FULL
>
> And in sysfs, it use show_slab_objects() and cpu_partial_slabs_show() to
> reflect the statistics.
>
> In patch 2, it splits some function in show_slab_objects() which makes sure
> only cpu_partial_slabs_show() covers statistics for CPU_PARTIAL slabs.
>
> After doing so, it would be more clear that show_slab_objects() has totally 9
> statistic combinations for three level of slabs. Each slab has three cases
> statistic.
>
> slabs
> objects
> total_objects
That sounds good.
> which is a little bit hard for users to understand. The second three patches
> rename sysfs file in this pattern.
>
> xxx_slabs[[_total]_objects]
>
> Finally it looks Like
>
> slabs
> slabs_objects
> slabs_total_objects
> cpu_slabs
> cpu_slabs_objects
> cpu_slabs_total_objects
> partial_slabs
> partial_slabs_objects
> partial_slabs_total_objects
> cpu_partial_slabs
Arent we missing:
cpu_partial_slabs_objects
cpu_partial_slabs_total_objects
And the partial slabs exclude the cpu slabs as well as the cpu_partial
slabs?
Could you add some documentation as well to explain the exact semantics?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-05-17 14:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 14:11 Wei Yang
2017-05-17 14:11 ` [PATCH 1/6] mm/slub: add total_objects_partial sysfs Wei Yang
2017-05-17 14:50 ` Christoph Lameter
2017-05-17 14:11 ` [PATCH 2/6] mm/slub: not include cpu_partial data in cpu_slabs sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 3/6] mm/slub: add cpu_slabs_[total_]objects sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 4/6] mm/slub: rename ALL slabs sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 5/6] mm/slub: rename partial_slabs sysfs Wei Yang
2017-05-17 14:11 ` [PATCH 6/6] mm/slub: rename cpu_partial_slab sysfs Wei Yang
2017-05-17 14:57 ` Christoph Lameter [this message]
2017-05-18 9:06 ` [PATCH 0/6] refine and rename slub sysfs Michal Hocko
2017-05-23 3:27 ` Wei Yang
2017-05-23 6:39 ` Michal Hocko
2017-05-23 16:07 ` Christoph Lameter
2017-05-24 9:54 ` Wei Yang
2017-05-24 12:03 ` Michal Hocko
2017-05-24 15:21 ` Wei Yang
2017-05-24 16:03 ` Christoph Lameter
2017-05-25 6:49 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1705170954090.8714@east.gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=richard.weiyang@gmail.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox