From: Thomas Gleixner <tglx@linutronix.de>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org,
tj@kernel.org, dyoung@redhat.com, isimatu.yasuaki@jp.fujitsu.com,
yasu.isimatu@gmail.com, lcapitulino@redhat.com,
qiuxishi@huawei.com, will.deacon@arm.com, tony.luck@intel.com,
vladimir.murzin@arm.com, fabf@skynet.be, kuleshovmail@gmail.com,
bhe@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mem-hotplug: Handle node hole when initializing numa_meminfo.
Date: Fri, 17 Jul 2015 11:10:11 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1507171107540.18576@nanos> (raw)
In-Reply-To: <1437096211-28605-3-git-send-email-tangchen@cn.fujitsu.com>
On Fri, 17 Jul 2015, Tang Chen wrote:
> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
> index d312ae3..c518eb5 100644
> --- a/include/linux/memblock.h
> +++ b/include/linux/memblock.h
> @@ -77,6 +77,8 @@ int memblock_remove(phys_addr_t base, phys_addr_t size);
> int memblock_free(phys_addr_t base, phys_addr_t size);
> int memblock_reserve(phys_addr_t base, phys_addr_t size);
> void memblock_trim_memory(phys_addr_t align);
> +bool memblock_overlaps_region(struct memblock_type *type,
> + phys_addr_t base, phys_addr_t size);
> -static bool __init_memblock memblock_overlaps_region(struct memblock_type *type,
> +bool __init_memblock memblock_overlaps_region(struct memblock_type *type,
> phys_addr_t base, phys_addr_t size)
> {
> unsigned long i;
This is silly. You change that function in the first patch already, so
why don't you make it globally visible there and then have the user.
Other than that:
Acked-by: Thomas Gleixner <tglx@linutronix.de>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2015-07-17 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 1:23 [PATCH 0/2] " Tang Chen
2015-07-17 1:23 ` [PATCH 1/2] memblock: Make memblock_overlaps_region() return bool Tang Chen
2015-07-17 1:23 ` [PATCH 2/2] mem-hotplug: Handle node hole when initializing numa_meminfo Tang Chen
2015-07-17 9:10 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507171107540.18576@nanos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=fabf@skynet.be \
--cc=hpa@zytor.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=kuleshovmail@gmail.com \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=qiuxishi@huawei.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tj@kernel.org \
--cc=tony.luck@intel.com \
--cc=vladimir.murzin@arm.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox