From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ig0-f169.google.com (mail-ig0-f169.google.com [209.85.213.169]) by kanga.kvack.org (Postfix) with ESMTP id 2649928033A for ; Fri, 17 Jul 2015 11:09:51 -0400 (EDT) Received: by igvi1 with SMTP id i1so37223301igv.1 for ; Fri, 17 Jul 2015 08:09:51 -0700 (PDT) Received: from resqmta-ch2-01v.sys.comcast.net (resqmta-ch2-01v.sys.comcast.net. [2001:558:fe21:29:69:252:207:33]) by mx.google.com with ESMTPS id l1si9456595iol.110.2015.07.17.08.09.50 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 17 Jul 2015 08:09:50 -0700 (PDT) Date: Fri, 17 Jul 2015 10:09:49 -0500 (CDT) From: Christoph Lameter Subject: Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime In-Reply-To: Message-ID: References: <20150714131704.21442.17939.stgit@buzz> <20150714131705.21442.99279.stgit@buzz> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Konstantin Khlebnikov Cc: Konstantin Khlebnikov , "linux-mm@kvack.org" , Andrew Morton , Linux Kernel Mailing List On Fri, 17 Jul 2015, Konstantin Khlebnikov wrote: > > Hrm.... Bad. Maybe drop the checks for the debug options that can be > > configured when merging slabs? They do not influence the object layout > > per definition. > > I don't understand that. Debug options do changes in object layout. Only some debug options change the object layout and those are alrady forbidden for caches with objects. > Since they add significant performance overhead and cannot be undone in runtime > it's unlikely that anyone who uses them don't care about merging after that. Those that do not affect the object layout can be undone. > Also I don't see how merging could affect debugging in positive way > (except debugging bugs in merging logic itself). The problem here is that debugging is switched on for slabs that are already merged right? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org