From: Christoph Lameter <cl@linux.com>
To: Konstantin Khlebnikov <koct9i@gmail.com>
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime
Date: Fri, 17 Jul 2015 10:09:49 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1507171008080.17929@east.gentwo.org> (raw)
In-Reply-To: <CALYGNiM6iKzwSiKRu79N-pjnSQZR_P3t9q50vV3cHtvLQz=dCA@mail.gmail.com>
On Fri, 17 Jul 2015, Konstantin Khlebnikov wrote:
> > Hrm.... Bad. Maybe drop the checks for the debug options that can be
> > configured when merging slabs? They do not influence the object layout
> > per definition.
>
> I don't understand that. Debug options do changes in object layout.
Only some debug options change the object layout and those are alrady
forbidden for caches with objects.
> Since they add significant performance overhead and cannot be undone in runtime
> it's unlikely that anyone who uses them don't care about merging after that.
Those that do not affect the object layout can be undone.
> Also I don't see how merging could affect debugging in positive way
> (except debugging bugs in merging logic itself).
The problem here is that debugging is switched on for slabs that are
already merged right?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-07-17 15:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 13:17 [PATCH 1/2] mm/slub: fix slab double-free in case of duplicate sysfs filename Konstantin Khlebnikov
2015-07-14 13:17 ` [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime Konstantin Khlebnikov
2015-07-14 18:11 ` Christoph Lameter
2015-07-14 20:21 ` Konstantin Khlebnikov
2015-07-14 21:18 ` Christoph Lameter
2015-07-17 9:37 ` Konstantin Khlebnikov
2015-07-17 15:09 ` Christoph Lameter [this message]
2015-07-17 15:25 ` Konstantin Khlebnikov
2015-07-14 18:11 ` [PATCH 1/2] mm/slub: fix slab double-free in case of duplicate sysfs filename Christoph Lameter
2015-07-16 0:27 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1507171008080.17929@east.gentwo.org \
--to=cl@linux.com \
--cc=akpm@linux-foundation.org \
--cc=khlebnikov@yandex-team.ru \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox